-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react): add initial content switcher refactor #9576
feat(react): add initial content switcher refactor #9576
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: 955aa47 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61391da7a7a11800070d2924 😎 Browse the preview: https://deploy-preview-9576--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: 955aa47 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61391da71b0a8c0007500c16 😎 Browse the preview: https://deploy-preview-9576--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: 955aa47 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61391da7797c390007761175 😎 Browse the preview: https://deploy-preview-9576--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab focus working as expected, arrow key navigation working, selection via enter / spacebar working, and no accessibility violations 👍🏻 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checks out on Edge 👍🏾
Initial implementation of #9519
This PR adds in a base implementation and API for the new
ContentSwitcher
componentChangelog
New
ContentSwitcher
for v11Changed
Removed
Testing / Reviewing
packages/react
next/ContentSwitcher-story.js
that saysincludeStories: []