Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-indicator): fix vertical small screen bug #9598

Merged
merged 12 commits into from
Sep 22, 2021
Merged

fix(progress-indicator): fix vertical small screen bug #9598

merged 12 commits into from
Sep 22, 2021

Conversation

andreancardona
Copy link
Contributor

Closes #9261

Testing

  • Checkout the progress indicator / change the knob to vertical / add a long title to one of the options
  • In the inspector, change the screen to be less than 307px
  • The lines should no longer push into the left border and should look like below

Screen Shot 2021-09-03 at 10 18 18 AM

@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 1df10dc

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614b3651714c5a00079deb0c

😎 Browse the preview: https://deploy-preview-9598--carbon-react-next.netlify.app

@andreancardona andreancardona changed the title 9261 vertincal progress indicator bug fix(progress-indicator): fix vertical small screen bug Sep 3, 2021
@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 54797d6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61323dd8383ece00081546dc

😎 Browse the preview: https://deploy-preview-9598--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 54797d6

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61323dd8eec6070008eb4d79

😎 Browse the preview: https://deploy-preview-9598--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 1df10dc

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614b36511aaecd00087db45e

😎 Browse the preview: https://deploy-preview-9598--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 3, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 1df10dc

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614b365128b06b00087cc382

😎 Browse the preview: https://deploy-preview-9598--carbon-components-react.netlify.app

@jnm2377
Copy link
Contributor

jnm2377 commented Sep 4, 2021

Hmm.. wondering if we should be finding a way to implement an ellipsis or somehow be more specific about text wrapping. The issue still occurs below 307 breakpoint, but also I think it could happen at any breakpoint if the vertical progress indicator is within a small container:
Screen Shot 2021-09-04 at 6 46 33 PM
Screen Shot 2021-09-04 at 6 43 35 PM

@joshblack
Copy link
Contributor

@jnm2377 that makes sense, if we could have the text wrap then it would really help us out here since we need to use tooltips as soon as ellipsis get introduced 😞

@andreancardona
Copy link
Contributor Author

@joshblack @jnm2377 Just pushed up a fix. let me know what you think!

@andreancardona andreancardona enabled auto-merge (squash) September 22, 2021 13:57
@andreancardona andreancardona merged commit 49e5a26 into carbon-design-system:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertical Progress Indicator: missing spacing when flex wraps on narrow widths
3 participants