-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ProgressIndicator): remove non-interactive active state #9631
fix(ProgressIndicator): remove non-interactive active state #9631
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: ac0b92f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6144f0a84dc35a0008a78086 😎 Browse the preview: https://deploy-preview-9631--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: ac0b92f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6144f0a8cd344b0007a9e34a 😎 Browse the preview: https://deploy-preview-9631--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: ac0b92f 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6144f0a8d98b4c0008f9c935 😎 Browse the preview: https://deploy-preview-9631--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works well for me on Edge in Ubuntu 🏄🏾
I think it also need to account for interactive/clickable (non-tooltip) steps. Right now, this change would also remove the active styling for the progress steps in the "interactive" story: https://deploy-preview-9631--carbon-components-react.netlify.app/?path=/story/components-progressindicator--interactive |
Closes #9609
Ensures a non-interactive
ProgressIndicator
step does not receive an active stateChangelog
Changed
active
styles to the node that contains a tooltipTesting / Reviewing
Click and drag the first step in the
ProgressIndicator
story. It should not receive any active styles