Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ProgressIndicator): remove non-interactive active state #9631

Merged

Conversation

tw15egan
Copy link
Collaborator

Closes #9609

Ensures a non-interactive ProgressIndicator step does not receive an active state

Changelog

Changed

  • Scoped active styles to the node that contains a tooltip

Testing / Reviewing

Click and drag the first step in the ProgressIndicator story. It should not receive any active styles

@netlify
Copy link

netlify bot commented Sep 10, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: ac0b92f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6144f0a84dc35a0008a78086

😎 Browse the preview: https://deploy-preview-9631--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 10, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: ac0b92f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6144f0a8cd344b0007a9e34a

😎 Browse the preview: https://deploy-preview-9631--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 10, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: ac0b92f

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6144f0a8d98b4c0008f9c935

😎 Browse the preview: https://deploy-preview-9631--carbon-components-react.netlify.app

Copy link
Contributor

@dakahn dakahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works well for me on Edge in Ubuntu 🏄🏾

@janhassel
Copy link
Member

I think it also need to account for interactive/clickable (non-tooltip) steps. Right now, this change would also remove the active styling for the progress steps in the "interactive" story: https://deploy-preview-9631--carbon-components-react.netlify.app/?path=/story/components-progressindicator--interactive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ProgressStep changes style on drag even when it's not interactive
4 participants