Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DataTable): useStaticWidth fix for title/description #9632

Merged
merged 4 commits into from
Sep 20, 2021
Merged

fix(DataTable): useStaticWidth fix for title/description #9632

merged 4 commits into from
Sep 20, 2021

Conversation

tw15egan
Copy link
Collaborator

Closes #9515

Fixes an issue that occurred when using useStaticWidth prop in DataTable. This ensures that if a title/description are provided to TableContainer, they do not expand past the width of the Table itself

Changelog

New

  • Added a useStaticWidth knob to the storybook
  • useStaticWidth is now passed to TableContainer and a class is toggled based on its presence

Testing / Reviewing

Toggle the useStaticWidth knob and ensure the content does not overflow past the Table width

@tw15egan tw15egan requested review from a team as code owners September 10, 2021 11:50
@tw15egan tw15egan changed the title Static width table fix fix(DataTable): useStaticWidth fix for title/description Sep 10, 2021
@netlify
Copy link

netlify bot commented Sep 10, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 01017cc

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6148f94cf99ab70008ef6b8d

😎 Browse the preview: https://deploy-preview-9632--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 10, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 01017cc

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6148f94c593fc20008785715

😎 Browse the preview: https://deploy-preview-9632--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 10, 2021 •
edited
Loading

❌ Deploy Preview for carbon-elements failed.

🔨 Explore the source changes: 01017cc

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6148f94ce96b940007d7aa11

sstrubberg
sstrubberg approved these changes Sep 10, 2021
View reviewed changes
Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@kodiakhq kodiakhq bot merged commit 9bba19b into carbon-design-system:main Sep 20, 2021
@joshblack joshblack mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sstrubberg sstrubberg sstrubberg approved these changes

@joshblack joshblack joshblack approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DataTable useStaticWidth title/description small style bug
4 participants
@tw15egan @tay1orjones @joshblack @sstrubberg