-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datepicker): pass through flatpickr inline prop #9702
fix(datepicker): pass through flatpickr inline prop #9702
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: baee782 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614a4154851ea400075b050a 😎 Browse the preview: https://deploy-preview-9702--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: baee782 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614a4154c3cb4b0007ebd697 😎 Browse the preview: https://deploy-preview-9702--carbon-components-react.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: baee782 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614a4154367e7000071b13ad 😎 Browse the preview: https://deploy-preview-9702--carbon-elements.netlify.app |
…carbon into 5713-flatpickr-pass-through
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉
Closes #5713
Passes the
inline
prop through to flatpickr. As stated in the linked issue,inline
isn't something formally baked from a design standpoint but we shouldn't block teams from passing this through to meet their own unique use cases.To this end, I didn't add
inline
as part of the component API, but instead passed it through by spreading...rest
props and checking forinline
in componentDid/WillUpdate.Changelog
Changed
Testing / Reviewing
inline
should be able to be passed through to flatpickr from DatePicker