Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): pass through flatpickr inline prop #9702

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Sep 20, 2021

Closes #5713

Passes the inline prop through to flatpickr. As stated in the linked issue, inline isn't something formally baked from a design standpoint but we shouldn't block teams from passing this through to meet their own unique use cases.

To this end, I didn't add inline as part of the component API, but instead passed it through by spreading ...rest props and checking for inline in componentDid/WillUpdate.

Changelog

Changed

  • datepicker: pass through inline prop

Testing / Reviewing

  • Tests should pass, inline should be able to be passed through to flatpickr from DatePicker

@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: baee782

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/614a4154851ea400075b050a

😎 Browse the preview: https://deploy-preview-9702--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: baee782

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/614a4154c3cb4b0007ebd697

😎 Browse the preview: https://deploy-preview-9702--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Sep 20, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: baee782

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/614a4154367e7000071b13ad

😎 Browse the preview: https://deploy-preview-9702--carbon-elements.netlify.app

Copy link
Contributor

@abbeyhrt abbeyhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

@sstrubberg sstrubberg enabled auto-merge (squash) September 21, 2021 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass down options to Flatpickr on the DatePicker component
4 participants