Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DataTable): guard npe when cells being sorted do not exist #9714

Merged
merged 6 commits into from
Sep 22, 2021
Merged

fix(DataTable): guard npe when cells being sorted do not exist #9714

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e5178e8
fix(DataTable): guard npe when cells being sorted do not exist
hoiwingh Sep 21, 2021
2be4546
Merge branch 'main' into fix-sorting-npe
holmansze Sep 21, 2021
9529578
Merge branch 'main' into fix-sorting-npe
holmansze Sep 21, 2021
49c460b
fix(DataTable): add unit tests
hoiwingh Sep 22, 2021
e273fe3
Merge branch 'fix-sorting-npe' of https://github.com/holmansze/carbon…
hoiwingh Sep 22, 2021
d480901
Merge branch 'main' into fix-sorting-npe
kodiakhq[bot] Sep 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/react/src/components/DataTable/tools/sorting.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ export const sortRows = ({
rowIds.slice().sort((a, b) => {
const cellA = cellsById[getCellId(a, key)];
const cellB = cellsById[getCellId(b, key)];
return sortRow(cellA.value, cellB.value, {
return sortRow(cellA && cellA.value, cellB && cellB.value, {
key,
sortDirection,
locale,
Expand Down