Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react): update issue with combobox buttons overlapping #9742

Merged
merged 11 commits into from
Sep 28, 2021
Merged

fix(react): update issue with combobox buttons overlapping #9742

merged 11 commits into from
Sep 28, 2021

Conversation

andreancardona
Copy link
Contributor

Closes #9667

This PR adds a little more margin right to the combobox x button - so that they no longer over lap

  • Make sure they no longer overlap

Screen Shot 2021-09-24 at 1 04 48 PM

@andreancardona andreancardona requested a review from a team as a code owner September 24, 2021 18:18
@netlify
Copy link

netlify bot commented Sep 24, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 61a51d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/6153357a4801d00008527798

😎 Browse the preview: https://deploy-preview-9742--carbon-react-next.netlify.app

@netlify
Copy link

netlify bot commented Sep 24, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 61a51d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6153357ab6b9550007ac4fa1

😎 Browse the preview: https://deploy-preview-9742--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Sep 24, 2021 •
edited
Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 61a51d8

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6153357afde3cb0008d5395e

😎 Browse the preview: https://deploy-preview-9742--carbon-components-react.netlify.app

@joshblack joshblack changed the title 9667 combobox button overlapping fix(react): combobox button overlapping Sep 28, 2021
@joshblack joshblack changed the title fix(react): combobox button overlapping fix(react): update issue with combobox buttons overlapping Sep 28, 2021
@kodiakhq kodiakhq bot merged commit 58006cc into carbon-design-system:main Sep 28, 2021
@joshblack joshblack mentioned this pull request Sep 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledavila aledavila aledavila approved these changes

@tay1orjones tay1orjones tay1orjones approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: ComboBox clear and expand buttons are overlapping.
3 participants
@andreancardona @tay1orjones @aledavila