Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TextInput): link helper text to input in default state #9873

Conversation

dakahn
Copy link
Contributor

@dakahn dakahn commented Oct 15, 2021

Closes #9630

The text helper was not linked to the text input via aria-describedby in it's default state causing an accessibility error when the input was disabled. This adds a helper id and sets that id to the text which should clear the error

Testing / Reviewing

TextInput in it's disabled state should not throw an error in Accessibility Checker

@netlify
Copy link

netlify bot commented Oct 15, 2021

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: bef7432

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/618585aa0e7c9700076f4f82

😎 Browse the preview: https://deploy-preview-9873--carbon-react-next.netlify.app

@dakahn
Copy link
Contributor Author

dakahn commented Oct 15, 2021

@tombrunet still getting that error after setting the aria-describedby. 😕 could you take a look at this and see if i missed somethign?

@dakahn dakahn mentioned this pull request Oct 15, 2021
57 tasks
@netlify
Copy link

netlify bot commented Oct 15, 2021

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: bef7432

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/618585aa87ea790007c56845

😎 Browse the preview: https://deploy-preview-9873--carbon-components-react.netlify.app

@netlify
Copy link

netlify bot commented Oct 15, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: bef7432

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/618585aa66e6a90007547523

😎 Browse the preview: https://deploy-preview-9873--carbon-elements.netlify.app

@dakahn dakahn changed the title WIP | fix(TextInput): link helper text to input in default state fix(TextInput): link helper text to input in default state Oct 15, 2021
@dakahn
Copy link
Contributor Author

dakahn commented Oct 15, 2021

Nvm! Looks like it was some bug with my browser. Error's clear

@kodiakhq kodiakhq bot merged commit 6656a63 into carbon-design-system:main Nov 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[a11y]: disabled TextInput's helper text not programmatically linked
3 participants