New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(DataTable): fixes overflowing sort button and select column spacing #9956

Merged

jnm2377 merged 4 commits into carbon-design-system:main from jnm2377:table-checkbox

Oct 29, 2021

Contributor

jnm2377 commented Oct 27, 2021

Closes #9837

Changelog

adds specific width to checkbox column, so that it's not clipped by sortable headers.
adds selectable + sortable story under the Selection stories

Testing / Reviewing

Review the Select with Sortable story, review that the checkbox is no longer being clipped by the sortable header
there should still be 20px of spacing between the checkbox and the sortable header text (4px right padding on checkbox + 16px left padding on sortable btn)

jnm2377 added 2 commits

October 26, 2021 20:55


          fix: add width to checkbox column

cb0baef


          feat: add select/sort story

23e0661

jnm2377 requested a review from laurenmrice

October 27, 2021 02:03

jnm2377 requested a review from a team as a code owner

October 27, 2021 02:03

jnm2377 requested review from tay1orjones and sstrubberg

October 27, 2021 02:03

netlify bot commented Oct 27, 2021 •

edited

Loading

✔️ Deploy Preview for carbon-react-next ready!

🔨 Explore the source changes: 10eeca9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/617c21d0d0a89900075e556e

😎 Browse the preview: https://deploy-preview-9956--carbon-react-next.netlify.app


          feat: add fix to styles package

48231fc

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 23e0661

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/6178b37dfc9f0400080bfe43

😎 Browse the preview: https://deploy-preview-9956--carbon-elements.netlify.app

netlify bot commented Oct 27, 2021

✔️ Deploy Preview for carbon-components-react ready!

🔨 Explore the source changes: 23e0661

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/6178b37ddd01290007c53abc

😎 Browse the preview: https://deploy-preview-9956--carbon-components-react.netlify.app

netlify bot commented Oct 27, 2021 •

edited

Loading

✔️ Deploy Preview for carbon-elements ready!

🔨 Explore the source changes: 10eeca9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/617c21d07910540008801b20

😎 Browse the preview: https://deploy-preview-9956--carbon-elements.netlify.app

netlify bot commented Oct 27, 2021 •

edited

Loading

✔️ Deploy Preview for carbon-components-react ready!
Built without sensitive environment variables

🔨 Explore the source changes: 10eeca9

🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/617c21d023b0400007ae0277

😎 Browse the preview: https://deploy-preview-9956--carbon-components-react.netlify.app

sstrubberg approved these changes

View reviewed changes

Member

sstrubberg left a comment

Nicely done updating the @carbon/styles package too! 🚀

jnm2377 added status: one more review 👀 status: visual review 🔍 labels

laurenmrice approved these changes

View reviewed changes

Member

laurenmrice left a comment

Looks good to me!

jnm2377 removed the status: visual review 🔍 label

joshblack approved these changes

View reviewed changes

joshblack added status: ready to merge 🎉 and removed status: one more review 👀 labels


          Merge branch 'main' into table-checkbox

10eeca9

jnm2377 enabled auto-merge (squash)

October 29, 2021 16:53

tay1orjones approved these changes

View reviewed changes

jnm2377 merged commit 6ce1b54 into carbon-design-system:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: ready to merge 🎉