-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): adjust bx--actions-list in data table to use display grid instead of position absolute #9994
Conversation
✔️ Deploy Preview for carbon-react-next ready! 🔨 Explore the source changes: bc51d17 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-react-next/deploys/61832c4f125efe0007786635 😎 Browse the preview: https://deploy-preview-9994--carbon-react-next.netlify.app |
✔️ Deploy Preview for carbon-elements ready! 🔨 Explore the source changes: bc51d17 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-elements/deploys/61832c4f5cb85d0007440bf8 😎 Browse the preview: https://deploy-preview-9994--carbon-elements.netlify.app |
✔️ Deploy Preview for carbon-components-react ready! 🔨 Explore the source changes: bc51d17 🔍 Inspect the deploy log: https://app.netlify.com/sites/carbon-components-react/deploys/61832c4fbdfabd00084a7910 😎 Browse the preview: https://deploy-preview-9994--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
When you hover over a button that is behind the summary, you can see that the summary isn't as tall as the buttons.
Would be cool if the summary could be the same height as the buttons, but that might be a limitation of the layout configuration happening here. In general this is a huge improvement as-is even without that piece.
@aagonzales Good catch! I fixed the scroll issue you pointed out and adjusted the height that Taylor mentioned, would you mind doing a quick re-review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Closes #9686
Updates how
bx--actions-list
is positioned so that whether or not it needs to scroll is sensed as expected. Because it was positioned absolutely, it didn't show the scroll bar when the items broke out of their parent container, this addresses that and adjusts the styles where needed.Changelog
New
Changed
position: absolute
neededRemoved
Testing / Reviewing
I added a story to DataTable w/ Batch Actions that has a ton of actions, shrink your screen until some aren't visible and make sure that the horizontal scroll bar appears and you can scroll to all the items.
The new story will be removed before merge.