feat: add request icon link to unassigned app icons #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonjoseph
requested review from
a team,
aledavila and
sstrubberg
and removed request for
a team
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/carbon-design-system/design-language-website/2phho9TgRtCpTtAG94cZxB28tx8z |
sstrubberg
approved these changes
Jan 25, 2022
alisonjoseph
requested review from
jeanservaas
and removed request for
aledavila
1 task
|
@jeanservaas @peter-garvin this ok to merge? or any updates needed? Thanks! |
|
I think this looks good but @peter-garvin should confirm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #999
Closes #759
https://design-language-website-git-fork-al-b68876-carbon-design-system.vercel.app/iconography/app-icons/library
Will have to scroll to find an "unassigned" icon to see the request button.
FYI @mjabbink @peter-garvin @jeanservaas Are we happy with the icon used, and also the colors, sizing, as there was no specific spec.
Request icon 32x32px with a 16px icon
on dark
icon fill-gray30
background- gray 100 hover
on light
icon fill-gray70
background-gray 10 hover