Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update Philosophy page #216

Merged
merged 4 commits into from
Aug 27, 2019
Merged

fix: update Philosophy page #216

merged 4 commits into from
Aug 27, 2019

Conversation

alisonjoseph
Copy link
Member

@alisonjoseph alisonjoseph commented Aug 26, 2019 •
edited
Loading

@netlify
Copy link

netlify bot commented Aug 26, 2019 •
edited
Loading

Deploy preview for design-language-website ready!

Built with commit 344ba73

https://deploy-preview-216--design-language-website.netlify.com

@alisonjoseph
Merge branch 'master' of github.com:carbon-design-system/design-langu…
9250690 
…age-website into philosophy-page

# Please enter a commit message to explain why this merge is necessary,
# especially if it merges an updated upstream into a topic branch.
#
# Lines starting with '#' will be ignored, and an empty message aborts
# the commit.
@jeanservaas
Copy link
Collaborator

This looks much better! Two things:

  1. did mike ask (@mjabbink) for the tab in on the blue call out quote to be removed entirely? Or just in mobile? Right now, it matches original IDL so I assume it's correct, but I thought I saw a comment about it.

  2. margin top on "Design is how we build bonds" seems smaller than the margin top above the other two H2s... I'd just make sure they're all 80px

@mjabbink
Copy link
Contributor

tab is correct but the type on the right side needs to be the same as the rest of the text. Just checking it is. So tabbed in on the left side but should not effect the right side.

@alisonjoseph
Copy link
Member Author

@mjabbink yep padding on the right side of the quote and paragraph length is being addressed in this PR in the theme carbon-design-system/gatsby-theme-carbon#374

Spacing above h2s should all be 80px from what I can tell.

@jeanservaas
Copy link
Collaborator

Gotcha, i see. right margin of quote text is still extending beyond right margin of the other body text.

image

@alisonjoseph
Copy link
Member Author

@jeanservaas yep we're fixing that in the theme right now!

@mjabbink
Copy link
Contributor

cool. Thanks both!

@alisonjoseph alisonjoseph mentioned this pull request Aug 27, 2019
Merged
jeanservaas
jeanservaas approved these changes Aug 27, 2019
View reviewed changes
Copy link
Collaborator

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm then

@alisonjoseph alisonjoseph merged commit a02fb84 into carbon-design-system:master Aug 27, 2019
@alisonjoseph alisonjoseph deleted the philosophy-page branch August 27, 2019 21:10
@mjabbink
Copy link
Contributor

mjabbink commented Mar 3, 2020

@alisonjoseph should this be closed? Looks resolved and released.

@alisonjoseph
Copy link
Member Author

alisonjoseph commented Mar 3, 2020 •
edited
Loading

this PR was merged/closed last summer @mjabbink 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanservaas jeanservaas jeanservaas approved these changes

Assignees
No one assigned
Labels
status: ready for review 👀 status: visual review 🔍
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alisonjoseph @jeanservaas @mjabbink