Skip to content

Commit

Permalink
Revert "build(deps): update node to 18 (#1278)"
Browse files Browse the repository at this point in the history
This reverts commit 1188ca2.
  • Loading branch information
eng618 authored Dec 1, 2022
1 parent 1188ca2 commit 04f20d0
Showing 12 changed files with 180 additions and 190 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/commitlint.yml
Original file line number Diff line number Diff line change
@@ -8,6 +8,6 @@ jobs:
- uses: actions/checkout@v2
with:
fetch-depth: 0
- uses: wagoid/commitlint-github-action@v5
- uses: wagoid/commitlint-github-action@v2.1.0
with:
helpURL: https://github.com/carbon-design-system/gatsby-theme-carbon/blob/main/docs/commitlint.md
8 changes: 4 additions & 4 deletions .github/workflows/manual-release.yml
Original file line number Diff line number Diff line change
@@ -3,18 +3,18 @@ on: workflow_dispatch

jobs:
release:
if: contains('["alisonjoseph", "sstrubberg", "eng618", "tay1orjones"]', github.actor)
if: contains('["alisonjoseph","vpicone", "sstrubberg", "jnm2377"]', github.actor)
runs-on: ubuntu-latest
steps:
# fetch-depth: 0 ensures we get commit messages for changelog/versioning
- uses: actions/checkout@v3
- uses: actions/checkout@v2
with:
fetch-depth: 0

- name: Set up node
uses: actions/setup-node@v3
uses: actions/setup-node@v2-beta
with:
node-version: 18.x
node-version: 14.x
registry-url: https://registry.npmjs.org

- name: Install dependencies
2 changes: 1 addition & 1 deletion .tool-versions
Original file line number Diff line number Diff line change
@@ -1 +1 @@
nodejs 18.12.1
nodejs 16.18.1
2 changes: 0 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -2,8 +2,6 @@
Gatsby Theme Carbon
</h1>

[![Netlify Status](https://api.netlify.com/api/v1/badges/62b47d2d-8b1e-4b21-994e-312b463d27de/deploy-status)](https://app.netlify.com/sites/gatsby-theme-carbon/deploys)

The Gatsby Carbon theme includes all the configuration you need to build a beautiful site inspired by the [Carbon Design System](https://www.carbondesignsystem.com).

## Resources
32 changes: 14 additions & 18 deletions docs/commitlint.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
# commitlint

## My pull request is failing! What Gives?

We use a tool called
@@ -10,35 +8,33 @@ packages based on the type of commit.
If you're here, odds are your pull request or a subsequent commit didn't adhere
to our guidelines.

### So what do I do about it?
## So what do I do about it?!

We need a commit message that describes what's happening in your commit, let's
build one.

#### Type
### Type

Commit messages need a type, pick the one below that best matches your commit:

**Release:** commits in this category will trigger a release of the package

- **fix**: a bug fix (triggers a `patch` release)
- **feat**: a new feature (triggers a `minor` release)
- fix: a bug fix (triggers a `patch` release)
- feat: a new feature (triggers a `minor` release)

**No release:** commits in this category won't trigger a release

- **build**: changes that affect the build system
- **ci**: changes to our CI configuration
- **chore**: dependency updates
- **docs**: documentation changes
- **perf**: performance improvements
- **refactor**: code change that neither fixes a bug, nor adds a feature
- **test**: adding or changing test files
- **revert**: undoes another commit
- **style**: changes that do not affect the meaning of the code
- build: changes that affect the build system
- ci: changes to our CI configuration
- chore: dependency updates
- docs: documentation changes
- perf: performance improvements
- refactor: code change that neither fixes a bug, nore adds a feature
- test: adding or changing test files

Commit messages should look like this:

#### Structure
### Structure

Your commit should look like this (keep everything lowercase, even React
components):
@@ -49,7 +45,7 @@ type(scope): subject # scope is optional, it refers to a particular component/fe

The `subject` is just a short summary of the code changes

#### Examples
### Examples

```bash
feat: add RTL support
@@ -59,7 +55,7 @@ feat: add RTL support
fix(aside): remove aside margin
```

#### Fixing the PR
### Fixing the PR

1. On the command line, navigate to the repository that contains the commit you
want to amend
6 changes: 2 additions & 4 deletions docs/development-principles.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# Development principles

## What should be a feature?
# What should be a feature?

When determining whether a not a new feature should be added to the theme, we
should run the feature through the following heuristic. The term `siteland`
@@ -15,7 +13,7 @@ If any of the above are false, we recommend building a solution in `siteland`
for the project that needs it most. This ensures we bring in mature, solutions
that have the largest likelihood of solving more problems than it causes.

## What constitutes a breaking change?
# What constitutes a breaking change?

A breaking change for the theme is one in which, after upgrading, a site is
unable to build.
8 changes: 3 additions & 5 deletions docs/releases.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
# Releases

## When does the theme publish releases?
# When does the theme publish releases?

At the moment, we intentionally publish releases manually. We want each release
to have meaning and reduce constant release churn. For that reason we release
@@ -14,7 +12,7 @@ when any of the following conditions are true:
If a patch is narrow in scope(impacting a small subset of sites) we'll hold off
on releasing the patch for the reasons mentioned above.

## How to publish a new theme version
# How to publish a new theme version

We publish to npm, create a GitHub release, and generate changelogs by using
[release-it](https://www.npmjs.com/package/release-it). To practice, use
@@ -29,7 +27,7 @@ not actually do anything.
4. Complete the prompts
5. 🚀 You did it! 🥳

## Updating the starter
# Updating the starter

If there's been a feature release/substantial change to the example project, you
should update the gatsby starter kit
32 changes: 16 additions & 16 deletions package.json
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@
},
"license": "Apache 2.0",
"engines": {
"node": "18.x"
"node": "14.x || 16.x"
},
"workspaces": [
"packages/*"
@@ -77,28 +77,28 @@
"dependencies": {
"@commitlint/cli": "^11.0.0",
"@commitlint/config-conventional": "^11.0.0",
"@release-it/conventional-changelog": "^2.0.1",
"@release-it/conventional-changelog": "^2.0.0",
"babel-eslint": "^10.1.0",
"eslint": "^6.8.0",
"eslint-config-airbnb": "^18.2.1",
"eslint-config-prettier": "^6.15.0",
"eslint-config-airbnb": "^18.1.0",
"eslint-config-prettier": "^6.10.1",
"eslint-config-wesbos": "0.0.19",
"eslint-plugin-html": "^6.2.0",
"eslint-plugin-import": "^2.26.0",
"eslint-plugin-jsx-a11y": "^6.6.1",
"eslint-plugin-prettier": "^3.4.1",
"eslint-plugin-react": "^7.31.10",
"eslint-plugin-html": "^6.0.0",
"eslint-plugin-import": "^2.17.2",
"eslint-plugin-jsx-a11y": "^6.2.1",
"eslint-plugin-prettier": "^3.0.1",
"eslint-plugin-react": "^7.19.0",
"eslint-plugin-react-hooks": "^2.5.1",
"husky": "^4.3.8",
"husky": "^4.2.3",
"lerna": "^3.22.1",
"lint-staged": "^10.5.4",
"prettier": "^2.7.1",
"lint-staged": "^10.0.9",
"prettier": "^2.5.1",
"prettier-config-carbon": "^0.2.0",
"release-it": "^14.14.3",
"release-it": "^14.6.1",
"release-it-yarn-workspaces": "^2.0.1",
"stylelint": "^13.13.1",
"stylelint-config-recommended-scss": "^4.3.0",
"stylelint-scss": "^3.21.0"
"stylelint": "^13.2.1",
"stylelint-config-recommended-scss": "^4.2.0",
"stylelint-scss": "^3.16.0"
},
"version": "3.0.0",
"packageManager": "yarn@3.3.0"
2 changes: 1 addition & 1 deletion packages/example/README.md
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@

> Gatsby [themes](https://www.gatsbyjs.org/docs/themes/) encapsulate all of the
> configuration and implementation details of Gatsby websites. This is a
> starter-kit (boilerplate) with a dependency on the `gatsby-theme-carbon`
> starter-kit (boilerplate) with a dependancy on the `gatsby-theme-carbon`
> package. The primary goal of `gatsby-theme-carbon` is to get content authors
> speaking the IBM Design Language with Carbon as soon as possible. It includes
> some sample components/content demos in the `src/pages` directory.
2 changes: 1 addition & 1 deletion packages/example/package.json
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@
"clean": "gatsby clean"
},
"dependencies": {
"gatsby": "^4.24.8",
"gatsby": "^4.21.1",
"gatsby-theme-carbon": "^3.0.0",
"react": "^17.0.2",
"react-dom": "^17.0.2"
70 changes: 35 additions & 35 deletions packages/gatsby-theme-carbon/package.json
Original file line number Diff line number Diff line change
@@ -17,53 +17,53 @@
"react-dom": "^17.0.2"
},
"devDependencies": {
"gatsby": "^4.24.8",
"gatsby": "^4.21.1",
"react": "^17.0.2",
"react-dom": "^17.0.2"
},
"dependencies": {
"@babel/core": "^7.20.2",
"@carbon/elements": "^11.14.0",
"@carbon/grid": "^11.7.0",
"@carbon/pictograms-react": "^11.34.0",
"@carbon/react": "^1.17.0",
"@carbon/themes": "^11.12.0",
"@mdx-js/mdx": "^1.6.22",
"@mdx-js/react": "^1.6.22",
"@reach/router": "^1.3.4",
"@vimeo/player": "^2.18.0",
"@babel/core": "^7.14.6",
"@carbon/elements": "^11.8.0",
"@carbon/grid": "^11.5.0",
"@carbon/pictograms-react": "^11.30.0",
"@carbon/react": "^1.11.0",
"@carbon/themes": "^11.7.0",
"@mdx-js/mdx": "^1.5.5",
"@mdx-js/react": "^1.5.5",
"@reach/router": "^1.2.1",
"@vimeo/player": "^2.9.1",
"beautiful-react-hooks": "^0.23.1",
"classnames": "^2.3.2",
"copy-to-clipboard": "^3.3.3",
"focus-trap-react": "^8.11.3",
"gatsby-plugin-catch-links": "^4.24.0",
"classnames": "^2.2.6",
"copy-to-clipboard": "^3.2.0",
"focus-trap-react": "^8.4.2",
"gatsby-plugin-catch-links": "^4.21.0",
"gatsby-plugin-lunr": "^1.5.2",
"gatsby-plugin-manifest": "^4.24.0",
"gatsby-plugin-manifest": "^4.21.0",
"gatsby-plugin-mdx": "3.20.0",
"gatsby-plugin-offline": "^5.24.0",
"gatsby-plugin-react-helmet": "^5.24.0",
"gatsby-plugin-sass": "5.24.0",
"gatsby-plugin-offline": "^5.21.0",
"gatsby-plugin-react-helmet": "^5.21.0",
"gatsby-plugin-sass": "5.9",
"gatsby-plugin-sass-resources": "^3.0.1",
"gatsby-plugin-sharp": "^4.24.0",
"gatsby-remark-copy-linked-files": "^5.24.0",
"gatsby-remark-images": "^6.24.0",
"gatsby-remark-responsive-iframe": "^5.24.0",
"gatsby-remark-smartypants": "^5.24.0",
"gatsby-plugin-sharp": "^4.21.0",
"gatsby-remark-copy-linked-files": "^5.21.0",
"gatsby-remark-images": "^6.21.0",
"gatsby-remark-responsive-iframe": "^5.21.0",
"gatsby-remark-smartypants": "^5.21.0",
"gatsby-remark-unwrap-images": "^1.0.2",
"gatsby-source-filesystem": "^4.24.0",
"gatsby-source-filesystem": "^4.21.1",
"gatsby-source-medium-feed": "^1.0.6",
"gatsby-transformer-yaml": "^4.24.0",
"gatsby-transformer-yaml": "^4.21.0",
"lodash.startcase": "^4.4.0",
"lodash.throttle": "^4.1.1",
"mkdirp": "^1.0.4",
"prism-react-renderer": "^1.3.5",
"prop-types": "^15.8.1",
"react-helmet": "^6.1.0",
"react-transition-group": "^4.4.5",
"react-use": "^15.3.8",
"remark-slug": "^6.1.0",
"sass": "^1.56.1",
"slugify": "^1.6.5",
"mkdirp": "^1.0.3",
"prism-react-renderer": "^1.2.1",
"prop-types": "^15.7.2",
"react-helmet": "^6.0.0-beta",
"react-transition-group": "^4.4.2",
"react-use": "^15.3.4",
"remark-slug": "^6.0.0",
"sass": "^1.52.3",
"slugify": "^1.3.4",
"smooth-scroll": "^16.1.3",
"use-media": "^1.4.0"
}
Loading

0 comments on commit 04f20d0

Please sign in to comment.