fix(image-card): render as div if no href is provided (#515)

* fix(image-card): render as div if no href is provided * fix(image-card): adjust logic for checking undefined href
carbon-design-system · Nov 13, 2019 · cb3769b · cb3769b · vercel · Nov 13, 2019
1 parent 19b5e70
commit cb3769b
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/packages/gatsby-theme-carbon/src/components/ImageCard/ImageCard.js b/packages/gatsby-theme-carbon/src/components/ImageCard/ImageCard.js
@@ -117,10 +117,9 @@ export default class ImageCard extends React.Component {
       [`${prefix}--aspect-ratio--4x3`]: aspectRatio === '4:3',
     });
 
-    const carbonTileclassNames = classnames(
-      [`${prefix}--tile`],
-      [`${prefix}--tile--clickable`]
-    );
+    const carbonTileclassNames = classnames([`${prefix}--tile`], {
+      [`${prefix}--tile--clickable`]: href !== undefined,
+    });
 
     const titleClassNames = classnames([`${prefix}--image-card__title`], {
       [`${prefix}--image-card__title--dark`]: titleColor === 'dark',
@@ -160,7 +159,7 @@ export default class ImageCard extends React.Component {
     );
 
     let cardContainer;
-    if (disabled === true) {
+    if (disabled === true || href === undefined) {
       cardContainer = <div className={carbonTileclassNames}>{cardContent}</div>;
     } else if (isLink === true) {
       cardContainer = (