fix: console errors

carbon-design-system · Apr 30, 2019 · d823c8e · d823c8e
1 parent 8730052
commit d823c8e
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 2 deletions.
diff --git a/package.json b/package.json
@@ -12,7 +12,7 @@
   "scripts": {
     "dev": "yarn workspace example develop",
     "build": "yarn workspace example build",
-    "serve": "yarn workspace example serve",
+    "serve": "yarn build && yarn workspace example serve",
     "now-build": "yarn workspace example build",
     "lint": "eslint ."
   },

diff --git a/packages/gatsby-theme-carbon/src/components/LeftNav/LeftNavItem.js b/packages/gatsby-theme-carbon/src/components/LeftNav/LeftNavItem.js
@@ -19,6 +19,7 @@ const LeftNavItem = props => {
     return (
       <SideNavLink
         onClick={closeLeftNav}
+        icon={<span>dummy icon</span>}
         element={Link}
         partiallyActive
         activeClassName="bx--side-nav__link--current"
@@ -33,6 +34,7 @@ const LeftNavItem = props => {
     <Location>
       {({ location }) => (
         <SideNavMenu
+          icon={<span>dummy icon</span>}
           isActive={location.pathname.includes(
             slugify(category, { lower: true })
           )} // TODO similar categories

diff --git a/packages/gatsby-theme-carbon/src/components/LeftNav/LeftNavWrapper.js b/packages/gatsby-theme-carbon/src/components/LeftNav/LeftNavWrapper.js
@@ -8,7 +8,10 @@ const LeftNavWrapper = styled.div(({ expanded }) => ({
   position: 'fixed',
   left: 0,
   zIndex: 8000,
-  transform: expanded ? 'translateX(0px)' : 'translateX(-260px)',
+  transform: expanded ? 'translateX(0px)' : 'translateX(-256px)',
+  '.bx--side-nav.bx--side-nav--website': {
+    boxShadow: expanded ? '0 2px 8px rgba(0, 0, 0, 0.2)' : 'none',
+  },
   [mq.lg]: {
     transform: 'translateX(0px)',
     '.bx--side-nav.bx--side-nav--website': {

diff --git a/packages/gatsby-theme-carbon/src/components/LeftNav/ResourceLinks.js b/packages/gatsby-theme-carbon/src/components/LeftNav/ResourceLinks.js
@@ -9,6 +9,7 @@ const LeftNavResourceLinks = ({ links }) =>
       <hr className="bx--side-nav__divider" />
       {links.map((link, i) => (
         <SideNavLink
+          key={i}
           style={{ marginTop: i === 0 ? '1rem' : 0 }}
           icon={<LaunchIcon />}
           href={link.href}