Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockquote width is off #172

Closed
alisonjoseph opened this issue Jun 14, 2019 · 0 comments · Fixed by #185
Closed

Blockquote width is off #172

alisonjoseph opened this issue Jun 14, 2019 · 0 comments · Fixed by #185

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented Jun 14, 2019

these are the styles we're missing

blockquote .#{$prefix}--paragraph {
  @include carbon--type-style('expressive-heading-03');
  @include carbon--breakpoint('md') {
    width: calc(62.5% - 3rem);
  }

  // 8 columns wide
  @include carbon--breakpoint('lg') {
    width: calc(66.667% - 3rem);
  }
}

Screen Shot 2019-06-14 at 7 44 46 AM

See this page for example of correct spacng https://www.ibm.com/design/language/philosophy

@alisonjoseph alisonjoseph changed the title Paragraph / blockquote inside columns Blockquote width is off Jun 14, 2019
@alisonjoseph alisonjoseph reopened this Jun 14, 2019
vpicone added a commit to vpicone/gatsby-theme-carbon that referenced this issue Jun 20, 2019
closes carbon-design-system#182, closes carbon-design-system#172

Also adds styles for blockquote citations and uses more real
life block quote examples to the documentation for context.
vpicone added a commit that referenced this issue Jun 20, 2019
* fix: update various markdown widths

closes #182, closes #172

Also adds styles for blockquote citations and uses more real
life block quote examples to the documentation for context.

* fix: button regression closes #177
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant