fix: paragraph width / math #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-alisonjoseph-paragraph-grid.carbon-design-system.now.sh |
|
@jeanservaas Should the text be aligning with the second image here? @alisonjoseph mentioned that paragraphs typically have a 32px padding right but that seems to not necessarily be correct on the idl this pr
idl
|
|
confirmed w/ Jeanne over slack that we're good |
…-carbon into paragraph-grid # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
…-carbon into paragraph-grid * 'paragraph-grid' of github.com:alisonjoseph/gatsby-theme-carbon:
vpicone
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes incorrect right spacing for blockquotes carbon-design-system/design-language-website#216
Fixes incorrect math for paragraph widths. (needs to be inside a row for % to be correct)
screenshot with some demo styles showing how things align correctly whether inside or outside column/rows