Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

global: body copy width should be 8 columns wide minus 32px #99

Closed
mjabbink opened this issue May 23, 2019 · 12 comments · Fixed by #156
Closed

global: body copy width should be 8 columns wide minus 32px #99

mjabbink opened this issue May 23, 2019 · 12 comments · Fixed by #156
Assignees
@alisonjoseph
Labels
role: dev 🤖 type: bug 🐛

Comments

@mjabbink
Copy link
Contributor

@vpicone @alisonjoseph Double check with Jeannie but I think she created this ish in Carbon site and has not yet moved here.
@alisonjoseph
Copy link
Member

She created the issue both places #55

@mjabbink
Copy link
Contributor Author

@alisonjoseph @vpicone Did this get done? It’s not reflected in the Gatsby them site yet.

@alisonjoseph
Copy link
Member

I think it's in an open PR that hasn't gotten merged, I can push just this update in though now.

@alisonjoseph alisonjoseph mentioned this issue May 30, 2019
Merged
@mjabbink
Copy link
Contributor Author

👍

@mjabbink
Copy link
Contributor Author

mjabbink commented Jun 3, 2019 •
edited
Loading

@alisonjoseph @vpicone The body copy expands the full 8 columns. It should be minus 32px so it does not go all the way to the far edge of the 8th column. Also looks like some text is going beyond the 8 columns.
https://gatsby-theme-carbon.now.sh/components/demo

@vpicone vpicone reopened this Jun 3, 2019
@vpicone vpicone closed this as completed in 63d9a5b Jun 3, 2019
vpicone added a commit that referenced this issue Jun 3, 2019
@vpicone
fix: paragraph length closes #99 (#137)
46086a6 
fix: paragraph length closes #99
@mjabbink
Copy link
Contributor Author

mjabbink commented Jun 4, 2019 •
edited
Loading

What’s the status on this ish? Does not look updated.

@mjabbink
Copy link
Contributor Author

mjabbink commented Jun 4, 2019

Screen Shot 2019-06-04 at 8 33 36 AM

@alisonjoseph alisonjoseph reopened this Jun 5, 2019
@alisonjoseph alisonjoseph mentioned this issue Jun 5, 2019
Closed
1 task
@alisonjoseph alisonjoseph self-assigned this Jun 10, 2019
@alisonjoseph
Copy link
Member

Where is the above screenshot from? I checked and this seems ok in the actual theme.
Screen Shot 2019-06-10 at 12 50 08 PM

@mjabbink
Copy link
Contributor Author

The above one is from brand Center
https://www.ibm.com/brand/expression

@alisonjoseph
Copy link
Member

got it, looks like its too much padding now. will look into it
Screen Shot 2019-06-10 at 1 15 55 PM

@mjabbink
Copy link
Contributor Author

Does look like too much now.

👍

@alisonjoseph alisonjoseph mentioned this issue Jun 10, 2019
Merged
@alisonjoseph
Copy link
Member

got a fix in this PR #156
Screen Shot 2019-06-10 at 1 28 12 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alisonjoseph alisonjoseph

Labels
role: dev 🤖 type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: various small fixes (Aside, DoDont & switcher icons)
3 participants
@alisonjoseph @vpicone @mjabbink