Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): update search styles #1050

Merged
merged 6 commits into from
Nov 9, 2020
Merged

fix(search): update search styles #1050

merged 6 commits into from
Nov 9, 2020

Conversation

alisonjoseph
Copy link
Member

Closes #1049

Changelog

  • Updated styles for search at all breakpoints. Should align on grid at desktop, and span full width at tablet/mobile.

@alisonjoseph alisonjoseph requested review from jeanservaas, a team, vpicone and sstrubberg and removed request for a team November 2, 2020 23:36
@vercel
Copy link

vercel bot commented Nov 2, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/carbon-design-system/gatsby-theme-carbon/8pbqup3lf
✅ Preview: https://gatsby-theme-carbon-git-search-box.carbon-design-system.vercel.app

Copy link
Member

@sstrubberg sstrubberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥

Copy link
Collaborator

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow quick turnaround! Looks good to me.

@vpicone vpicone merged commit bcc3f23 into carbon-design-system:main Nov 9, 2020
@mjabbink
Copy link
Contributor

Way nicer and especially in mobile! Look forward to this puppy hitting the glass.

@mjabbink
Copy link
Contributor

@alisonjoseph and @vpicone The above Preview link is what I was responding to in this issue and it’s not what is live. So Let’s get on a 5-minute call to clear up because I’m missing why we did not deploy this preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[search] extend search field in mobile to allow users to enter a term
5 participants