Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Tabs component #124

Merged
merged 4 commits into from
May 30, 2019
Merged

feat: Add Tabs component #124

merged 4 commits into from
May 30, 2019

Conversation

vpicone
Copy link
Contributor

@vpicone vpicone commented May 29, 2019

closes #14

  • Refactor/Rewrite WebsiteTabs
  • Add mobile styles
  • Add regular example
  • Add grid example

@vercel
Copy link

vercel bot commented May 29, 2019 •
edited
Loading

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-vpicone-tabs.carbon-design-system.now.sh

@vpicone vpicone requested a review from alisonjoseph May 29, 2019 22:11
@vpicone vpicone self-assigned this May 29, 2019
alisonjoseph
alisonjoseph reviewed May 30, 2019
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking so good!
Screen Shot 2019-05-29 at 10 35 17 PM
Screen Shot 2019-05-29 at 10 36 14 PM

Looks like styling still needs a little tweaking, there are some weird gaps at the large breakpoint and the dropdown I believe should go full width at mobile.

@vpicone
Copy link
Contributor Author

vpicone commented May 30, 2019

@alisonjoseph should be good to go

alisonjoseph
alisonjoseph approved these changes May 30, 2019
View reviewed changes
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! looks great

@alisonjoseph alisonjoseph mentioned this pull request May 30, 2019
Merged
@vpicone vpicone merged commit a4c216f into carbon-design-system:master May 30, 2019
@vpicone vpicone deleted the tabs branch May 30, 2019 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alisonjoseph alisonjoseph alisonjoseph approved these changes

Assignees

@vpicone vpicone

Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create WebsiteTabs component
2 participants
@vpicone @alisonjoseph