Use color tokens in FourOhFour styles #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
eng618
force-pushed
the
1309-color-tokens
branch
from
7feaa57 to
ed84be6
Compare
|
Hey @jt-nti any update on this? |
|
Hi @eng618, sorry I'd forgotten about this. The PR checks are failing and I didn't hear back from @alisonjoseph on issue #1309 so it's kind of in limbo I think. If I get a chance, I'll rebase the PR, set it to ready and see what happens. |
jt-nti
force-pushed
the
1309-color-tokens
branch
from
0f43cfd to
9f95023
Compare
jt-nti
changed the title
|
The PR checks are still failing but that looks like it's something |
eng618
force-pushed
the
1309-color-tokens
branch
from
9f95023 to
3995498
Compare
✅ Deploy Preview for gatsby-theme-carbon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
eng618
approved these changes
Feb 15, 2024
Fixes carbon-design-system#1309 Signed-off-by: James Taylor <jamest@uk.ibm.com>
eng618
force-pushed
the
1309-color-tokens
branch
from
3995498 to
230d6dc
Compare
|
Looks good in the preview
|
|
@jt-nti thanks for the contribution. I set up auto-merge, so once everything passes this should merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1309
Use correct tokens in 404 page theme
Changelog
Changed