feat(next): add max results to search #1466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alisonjoseph
commented
Apr 17, 2024
| @@ -33,9 +33,8 @@ import { | |||
|
|
|||
| import Menu, { MenuContext } from './Menu'; | |||
|
|
|||
| const MAX_RESULT_LIST_SIZE = 8; | |||
| const MAX_RESULT_LIST_SIZE = 12; | |||
There was a problem hiding this comment.
@eng618 I bumped the default to 12, will also double check with our designers on this, but easy to update later if needed
✅ Deploy Preview for gatsby-theme-carbon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
eng618
approved these changes
Apr 17, 2024
eng618
added a commit
that referenced
this pull request
May 23, 2024
* feat(deps): update node to 18 (#1278) * build(deps): update node to 18 Also update all other dependencies - update all minor dependencies #1277 * chore: bump everything to node 18 * chore: update gatsby-plugin-sass * chore: update readme with status badge * docs: typo correction * docs: update structure * ci: update .github/workflows/manual-release.yml Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> * ci: update commitlint version and docs Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> * chore: release 4.0.0-next.0 * chore: release 4.0.0-next.1 * build: bump deps * chore: release 4.0.0-next.2 * build: update node version * build: update deps * build: gatsby v5 * fix: run gatsby codemods npx gatsby-codemods@latest sort-and-aggr-graphql . * build: define trailingSlash * build: bump dependencies * refactor: apply formatting * refactor(eslint): comment out unused imorts * refactor: apply formatting * start update mdx * build(deps): bump minor and below versions * build: update lerna * formatting... * feat: update release-it * feat: update @commitlint * ci: add github actions updater * build: move some deps down to devDependencies * build: update all things * formatting... * build: dep updates * fix: remove extraLayouts This is not longer supported as you can define your own layouts as components, following this guide: https://www.gatsbyjs.com/docs/how-to/routing/layout-components/ * build: bump dependencies * chore: update sass resources loader to compatible version * build: bump deps * docs: start migration doc * chore: rebuild yarn lock * build(deps): update minor and below * build(deps): update minor and below * feat(layouts): start converting to use layouts * build: rebuild lock file * build: cleanup unknown property * build(deps): update minor and below * build(deps): bump minor and below * fix(path): update layout path * linter fixes * chore: update changelog settings * build(deps): bump minor and below And other minor adjustments. * chore: add recommended plugins * fix(scss): import + other minor fixes (#1410) * Fixing scss import + other minor fixes * Fixing useMetadata in Default Layout * lint fixing * bring back defaultProps * Fixing inline code blocks * Minor info comment * More suggested changes * remove white space * testing vercel again * Fixing yarn * fixing yarn * chore(deps): bump minor and below * fix(format): run prettier * fix(lint): update wesbos * fix: linting,imports in code (#1414) * build(deps): update release-it workspaces * docs: update code block * chore: release 4.0.0-next.4 [skip ci], * chore: update lock file * Fix : mdx tables + port to esm v2 (#1418) * fix: mdx tables + port gatsby core to ESM * chore: bring back js files via using type * updating the order of remarkGfm Co-authored-by: Eric Garcia <engarcia618@gmail.com> * fix: updatng remarkGfm order Co-authored-by: Eric Garcia <engarcia618@gmail.com> * chore: add a space * fix: mdx-tables --------- Co-authored-by: Eric Garcia <engarcia618@gmail.com> * fix(yarn): revert lock file changes * fix: v5 issues (#1431) * fix: image spacing * fix: blockquote styles * fix: prop table display * fix: image gallery display * fix: markdown link with title * docs: update migration guide * build: maintian dependencies * build: rebuild lock file * Fix: code blocks in mdx + issues/868 (#1422) * fix: heading spacing * build: bump yarn * fix: nested list styling for v5 (#1438) Co-authored-by: Eric Garcia <eng618@garciaericn.com> * style: apply formatting * chore: release 4.0.0-next.5.0 [skip ci], * build(deps): bump minor * fix: copy button color token (#1441) * fix: copy button color token * chore: remove extra file changes * fix: regression in code blocks - default prop (#1442) * docs: code blocks docs page (#1443) * docs: code snippet docs page * fix: hidecode prop check * fix formatting * fix: release * chore: release 4.0.0-next.7 [skip ci], * refactor: change hideCode prop to showAll prop (#1445) * refactor: change hideCode prop to showAll prop * fix: yan lock file * fix: feedback form button style * fix: warnings (#1450) * fix: warnings * fix: swap back to mjs file * fix: caption styles (#1451) * fix formatting * chore: release 4.0.0-next.8 [skip ci], * feat(next): add gatsby-plugin-local-search (#1464) * feat(next): add gatsby-plugin-local-search remove gatsby-plugin-lunr * feat(next): add gatsby-plugin-local-search remove gatsby-plugin-lunr * feat: add path * chore: remove old code * chore: clean up code * chore: cleanup * feat: fix tabs * feat: create search config file * chore: release 4.0.0-next.9 [skip ci], * feat: add max results to search (#1466) * chore: release 4.0.0-next.10 [skip ci], * build(deps): bump minor and below * chore: release 4.0.0-next.11 [skip ci], * build(yarn): update lock file * docs: update migration guide * fix(deps): add missing preset * docs: update migration guide * chore: cleanup * fix: update homepage link to v4 migration --------- Co-authored-by: Scott Strubberg <sstrubberg@protonmail.com> Co-authored-by: Mudit Juneja <muditjuneja@outlook.com> Co-authored-by: Alison Joseph <alisonejoseph@Gmail.com> Co-authored-by: Alison Joseph <alison.joseph@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.