Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent nav from collapsing during local development #1510

Merged

Conversation

matthewgallo
Copy link
Member

@matthewgallo matthewgallo commented Sep 11, 2024

This change includes the pathPrefix from NavContext and then passes it as a prop from LeftNav to LeftNavTree, this prevents rerendering and keeps the nav from collapsing.

Thanks to both @alisonjoseph and @davidmenendez for helping on this!

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 8:35pm

Copy link

netlify bot commented Sep 11, 2024

Deploy Preview for gatsby-theme-carbon ready!

Name Link
🔨 Latest commit d32cd22
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/66e1fe31ae57800008377d4e
😎 Deploy Preview https://deploy-preview-1510--gatsby-theme-carbon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@matthewgallo matthewgallo changed the title Path prefix bug fix fix: prevent nav from collapsing during local development Sep 11, 2024
@matthewgallo matthewgallo marked this pull request as ready for review September 11, 2024 20:03
@matthewgallo matthewgallo requested review from eng618 and a team as code owners September 11, 2024 20:03
@matthewgallo matthewgallo requested review from alisonjoseph and emyarod and removed request for a team September 11, 2024 20:03
Copy link
Contributor

@davidmenendez davidmenendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks to be working as expected locally and in the preview

@alisonjoseph alisonjoseph merged commit b907d88 into carbon-design-system:main Sep 11, 2024
8 checks passed
@matthewgallo matthewgallo deleted the path-prefix-bug-fix branch September 11, 2024 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants