Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(leftnavtree): highlight nav menu item for tabbed pages in level2 #1514

Merged
merged 3 commits into from
Sep 13, 2024

Conversation

szinta
Copy link
Contributor

@szinta szinta commented Sep 13, 2024

Closes #1511

In Level 2 pages, tabs highlight the last menu item within the respective Level 2 section

Changelog

Changed

  • Revised the logic for identifying the active menu item for the tabbed page.
  • Included an example for the tabbed page in Level 2.

@szinta szinta requested review from eng618 and a team as code owners September 13, 2024 12:26
@szinta szinta requested review from emyarod and guidari and removed request for a team September 13, 2024 12:26
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gatsby-theme-carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 13, 2024 1:17pm

Copy link

netlify bot commented Sep 13, 2024

Deploy Preview for gatsby-theme-carbon ready!

Name Link
🔨 Latest commit 661f2a2
🔍 Latest deploy log https://app.netlify.com/sites/gatsby-theme-carbon/deploys/66e43a83712481000818b3bd
😎 Deploy Preview https://deploy-preview-1514--gatsby-theme-carbon.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisonjoseph alisonjoseph merged commit 0d5f9d5 into carbon-design-system:main Sep 13, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tree nav: Tabbed pages in Level 2 highlighting wrong menu item
3 participants