fix: page description with tag spacing #1519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisonjoseph
requested review from
kennylam and
annawen1
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for gatsby-theme-carbon ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
laurenmrice
approved these changes
Sep 18, 2024
Kritvi-bhatia17
requested changes
Sep 19, 2024
There was a problem hiding this comment.
Hi @alisonjoseph,
The spacing from the top looks perfect now! If I’m looking at the right page, I noticed that the tag seems to have about 4px of padding on the left and right, which is why it’s not aligning with the bottom text on the left.
eng618
approved these changes
Sep 20, 2024
|
@Kritvi-bhatia17 just pushed an update to remove the left margin from the tag |
Kritvi-bhatia17
approved these changes
Sep 23, 2024
Kritvi-bhatia17
added
status: ready to merge 🎉
and removed
status: ready for review 👀
status: one more review 👀
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1517
Changelog
Changed
https://gatsby-theme-carbon-git-fork-alison-dacea3-carbon-design-system.vercel.app/components/PageDescription/