Markdown updates #170
Merged
Markdown updates #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically deployed with Now. Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-vpicone-markdown-updates.carbon-design-system.now.sh |
|
Since the h1 role effectively consumed by the page header, and h1s go unused in the mdx content, after this PR we now style h1 tags identically to h2 tags. The only difference is h1s have no margin-top. This means the start of your content be either a PageDescriptiobn or an h1 tag (single #). We recommend the former. We think for most content, PageDescription → AnchorLinks creates a nice hierarchy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #169, closes #68, closes #147
begins work on #105
This PR also separates out the MDXProvider from the components as passes the compmonents in as default props. In this way, devs can shadow the Provider and spread the default components that they don't want to override.
Major markdown components now have their styles colocated
components/markdown/Markdown.module.scsswhich allows for an easier whole-sale override.