Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update icon sizing for resource cards #273

Merged
merged 15 commits into from
Jul 30, 2019
Merged

fix: update icon sizing for resource cards #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
0ae5232
fix: update icon sizing for resource cards
alisonjoseph Jul 23, 2019
3b5604a
chore: update image size styles
alisonjoseph Jul 23, 2019
709d326
Merge branch 'master' into icon-size-bug
vpicone Jul 23, 2019
2517445
Merge branch 'master' into icon-size-bug
vpicone Jul 24, 2019
7c82419
fix: add min width
alisonjoseph Jul 24, 2019
c44f09e
Merge branch 'master' into icon-size-bug
vpicone Jul 25, 2019
750d69d
chore: add min-height
alisonjoseph Jul 26, 2019
634bda7
Merge branch 'master' into icon-size-bug
vpicone Jul 26, 2019
f93b778
Merge branch 'master' into icon-size-bug
vpicone Jul 29, 2019
1a4071e
Merge branch 'master' into icon-size-bug
vpicone Jul 29, 2019
57d7230
add position static to gatsby image wrapper
alisonjoseph Jul 29, 2019
d7155fe
chore: fix icon for real this time
alisonjoseph Jul 29, 2019
179544a
Merge branch 'master' into icon-size-bug
alisonjoseph Jul 29, 2019
bd41b35
chore: cleanup style order
alisonjoseph Jul 29, 2019
f73fdb6
Merge branch 'icon-size-bug' of github.com:alisonjoseph/gatsby-theme-…
alisonjoseph Jul 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,5 @@ yarn-error.log
.yarn-integrity

# Vscode settings
.vscode/settings.json
.vscode/settings.json
.vscode/tasks.json
8 changes: 7 additions & 1 deletion packages/gatsby-theme-carbon/src/components/ResourceCard/resource-card.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,10 @@
position: absolute;
bottom: 1rem;
left: 1rem;
width: 32px;
min-width: 32px;
min-height: 32px;
display: flex;
align-items: flex-end;
}

.#{$prefix}--resource-card__icon--img .gatsby-resp-image-wrapper,
Expand All @@ -38,6 +40,10 @@
margin-bottom: 0;
}

.#{$prefix}--resource-card__icon--img .gatsby-resp-image-wrapper {
position: static !important; //important needed to override inline style added by Gatsby
}

.#{$prefix}--resource-card__icon--action {
position: absolute;
bottom: 1rem;
Expand Down