Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ImageGallery): prevent page autoscroll on overlay open #378

Merged

Conversation

emyarod
Copy link
Member

@emyarod emyarod commented Aug 27, 2019

Closes #377

This PR changes the position rule for the gallery image dialog from absolute to fixed, which prevents the page from autoscrolling when an image overlay is opened

@vercel
Copy link

vercel bot commented Aug 27, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

Latest deployment for this branch: https://gatsby-theme-carbon-git-fork-emyarod-377-gallery-page-scrolling.carbon-design-system.now.sh

@vercel vercel bot temporarily deployed to staging August 27, 2019 14:04 Inactive
Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

were yarn.lock file changes intentional?

@emyarod
Copy link
Member Author

emyarod commented Aug 27, 2019

the lockfile changes appear after each time I run yarn install, I guess because the lockfile isn't frozen

@alisonjoseph alisonjoseph merged commit ba1f5fb into carbon-design-system:master Aug 28, 2019
@emyarod emyarod deleted the 377-gallery-page-scrolling branch August 29, 2019 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery: The overlay background always shows the top of page regardless of where you are in scroll
3 participants