fix(skip-to-content): add explicit href to component, add id to… #607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/carbon-design-system/gatsby-theme-carbon/fjyxu0rmt |
|
I like explicitly defining it as well, thanks for this! |
vpicone
approved these changes
Dec 12, 2019
vpicone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #606
The
SkipToContentcomponent needs to target part of the page so that keyboard users can jump to it, so I suggest addingid="main-content"to the<main>element of each page. NOTE: this would not include homepage, since it doesn't appear to have aSkipToContentlink -- is that acceptable?Also, since the default
hreffor theSkipToContentis#main-content, I suggest explicitly defining it where the component is used so that folks who come along later can quickly see where the link goes. 👍Changelog
New
href="#main-content"to theSkipToContentcomponentid="main-content"to the<main>element on each (non-homepage) page.