Polish out support for reals and strings. #2593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandlerc
approved these changes
Feb 10, 2023
| @@ -156,6 +156,7 @@ CARBON_KEYWORD_TOKEN(Return, "return") | |||
| CARBON_KEYWORD_TOKEN(Returned, "returned") | |||
| CARBON_KEYWORD_TOKEN(SelfParameter, "self") | |||
| CARBON_KEYWORD_TOKEN(SelfType, "Self") | |||
| CARBON_KEYWORD_TOKEN(StringTypeLiteral, "String") | |||
There was a problem hiding this comment.
Can you add a TODO or FIXME to document that this is a temporary thing until we have a prelude working?
There was a problem hiding this comment.
Can you add a TODO or FIXME to document that this is a temporary thing until we have a prelude working?
I'm adding a vague TODO per your request, but unless I'm misunderstanding the result of #2113 (comment), I don't think this is a "prelude working" problem... This is closer to the decision regarding Type versus type on #2360
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reals were mostly handled, but this PR adds storage of them. It also switches a little towards the FloatingPointType semantic from TokenizedBuffer.
While real literals like
1.0were handled, the type literals were not. This just addsf64, similar to how I also only supporti32.The String type literal wasn't used, so I've added support in lexer and parser. Per discussion with @zygoloid String might be renamed based on the newer type literal plan, but it's still String in explorer and the design, so this is just consistent.
The builtin_types.carbon tests the three basic types that are there right now. The test is added to both parser and semantics so that it's clear what the state is in both stages.