Refactor finalization of initializers. #3250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Factor out the common code to find the return slot for an initializing expression, and use it to simplify the two different ways we finalize initializers, as either initializing a temporary or initializing some specific object. This slightly changes the SemIR we create for function calls: instead of rewriting the Call node to have a different destination and replacing its temporary with a `no_op`, we now replace its temporary with a `stub_reference` to the new destination. This results in the same amount of SemIR being produced, but allows calls and other kinds of initializers to be handled uniformly.
chandlerc
approved these changes
Sep 21, 2023
| semantics_ir().ReplaceNode( | ||
| temporary_id, SemIR::Node::NoOp::Make(temporary.parse_node())); | ||
| if (!semantics_ir.GetFunction(callee_id).return_slot_id.is_valid()) { | ||
| return SemIR::NodeId::Invalid; |
There was a problem hiding this comment.
Hmm, is this going to cause the caller to restructure how the return is managed (making it not in-place)? For an invalid function, that seems like it might result in cascading errors. Should this instead return a return slot that is marked invalid? Or in some other way model that distinction?
There was a problem hiding this comment.
The situation being handled here is that the function doesn't have a return slot (which is modeled by the return slot ID being marked as invalid). Unfortunately, we fairly pervasively use SemIr::NodeId::Invalid to mean "none" (not a valid ID) rather than "the program is invalid". Perhaps we should rename it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factor out the common code to find the return slot for an initializing expression, and use it to simplify the two different ways we finalize initializers, as either initializing a temporary or initializing some specific object.
This slightly changes the SemIR we create for function calls: instead of rewriting the Call node to have a different destination and replacing its temporary with a
no_op, we now replace its temporary with astub_referenceto the new destination. This results in the same amount of SemIR being produced, but allows calls and other kinds of initializers to be handled uniformly.