More complete parsing support for functions. #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependent
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
fowles
reviewed
Apr 21, 2021
| has_errors); | ||
| }); | ||
|
|
||
| auto start_return_type = StartSubtree(); |
There was a problem hiding this comment.
I am a bit confused here. If there is no arrow, do we not need to close the subtree in some way?
There was a problem hiding this comment.
I think StartSubtree is perhaps not well-named; it just tracks a location where we could start a subtree. It's really just a stable handle to a location in the tree currently being built. Happy to rename. Something like GetPossibleSubtreeStartLocation but less wordy perhaps?
fowles
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for parsing function parameters, function return types, and return statements.
Depends on #473.