Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding meeting notes for Editors meeting 40 #230

Merged
merged 7 commits into from
Mar 15, 2022
Merged

Adding meeting notes for Editors meeting 40 #230

merged 7 commits into from
Mar 15, 2022

Conversation

mangelsjover
Copy link
Contributor

No description provided.

@rphair
Copy link
Collaborator

rphair commented Mar 4, 2022

Again, I wasn't at this meeting, but the formatting, readability & understandability are fine. I'll watch for approval from @KtorZ or @crptmppt and second it if they do... though it seems wrong to be the first reviewer because I wasn't at the meeting.

Regarding protocol & this item:

PR211 ... Yeah. We were waiting for review from Robert. It came two weeks ago, but we then kind of forgot to merge it.

Similarly, I didn't merge this myself after making the second approving review because I believed protocol was to wait for a discussion at the meeting, where it would be merged by one of the attendees. Hence the 2 week delay over a straightforward, already approved change. Now because of team member changes we might have to resolve these open PR's more aggressively

So unless anyone says otherwise, to avoid getting hung up... I'll plan to merge such reviews if it looks like consensus has already been achieved on Github itself (e.g. someone editing their own CIP, like this one) or perhaps a trivial change.

@rphair rphair requested a review from KtorZ March 4, 2022 04:25
Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sure if there were any problems with these minutes they would have been flagged by now 🤓

@rphair rphair merged commit dbca318 into cardano-foundation:master Mar 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants