CIP-5: script prefixes extension #31
Conversation
CIP5/README.md
Outdated
| @@ -48,6 +48,9 @@ We define the following set of common prefixes with their corresponding semantic | |||
| | `vrf_vk` | VRF verification key | | |||
| | `vrf_vkh` | VRF verification key hash | | |||
| | `vrf_sk` | VRF signing key | | |||
| | `script` | Script hash | | |||
| | `script_vkh` | Verification key hash of used in script | | |||
There was a problem hiding this comment.
*Verification key hash of key used in script?
There was a problem hiding this comment.
fixed in 6843b7b
CIP5/README.md
Outdated
| @@ -48,6 +48,9 @@ We define the following set of common prefixes with their corresponding semantic | |||
| | `vrf_vk` | VRF verification key | | |||
| | `vrf_vkh` | VRF verification key hash | | |||
| | `vrf_sk` | VRF signing key | | |||
| | `script` | Script hash | | |||
| | `script_vkh` | Verification key hash of used in script | | |||
| | `script_sk` | Signing key for vkh used in script | | |||
There was a problem hiding this comment.
Likewise, we should also include script_vk don't you think?
There was a problem hiding this comment.
added in 6843b7b
There was a problem hiding this comment.
It would be useful if this table had a "Contents" column like so...
| Prefix | Meaning | Contents |
| --- | --- | --- |
| `script_vkh` | Verification key hash used in script addresses | Hash of key |
| `script_vk` | Verification key for scripts | Verification/public key |
| `script_sk` | Signing key for script | Signing/private key |
There was a problem hiding this comment.
done in ea15443
paweljakubas
force-pushed
the
paweljakubas/script-prefixes
branch
from
a1e4902
to
6843b7b
Compare
CIP5/README.md
Outdated
| @@ -48,6 +48,9 @@ We define the following set of common prefixes with their corresponding semantic | |||
| | `vrf_vk` | VRF verification key | | |||
| | `vrf_vkh` | VRF verification key hash | | |||
| | `vrf_sk` | VRF signing key | | |||
| | `script` | Script hash | | |||
| | `script_vkh` | Verification key hash of used in script | | |||
| | `script_sk` | Signing key for vkh used in script | | |||
There was a problem hiding this comment.
It would be useful if this table had a "Contents" column like so...
| Prefix | Meaning | Contents |
| --- | --- | --- |
| `script_vkh` | Verification key hash used in script addresses | Hash of key |
| `script_vk` | Verification key for scripts | Verification/public key |
| `script_sk` | Signing key for script | Signing/private key |
ea15443
to
be5470c
Compare
CIP5/README.md
Outdated
| | `addr_test` | Testnet address | Network tag, payment credential and optional stake credential | | ||
| | `stake` | Mainnet stake address | Network tag and stake credential | | ||
| | `stake_test` | Testnet stake address | Network tag and stake credential | | ||
| | `script` | Script hash | blake2b\_224 digest of a serialized transaction script | |
There was a problem hiding this comment.
Shouldn't we also move this under the "Hashes" heading? Then we could change #### Miscellaneous to #### Addresses.
There was a problem hiding this comment.
It looks like this older PR needs to be rebased to be merged as it targets https://github.com/cardano-foundation/CIPs/blob/master/CIP-0005/CIP-0005.md
add script_vk
rewrite contents
KtorZ
force-pushed
the
paweljakubas/script-prefixes
branch
from
4f9429c
to
80148a7
Compare
|
@crptmppt rebased and addressed Luke's suggestion above 👍 |
|
@KtorZ: Just a note that it doesn't seem my comment was addressed (unless we're deciding to disregard it). |
|
@intricate it was... put I pushed on the wrong remote (origin vs paweljakubas) 🤦 ... (note: I've only addressed the first part about moving |
Hereby, we propose the prefixes for: