-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-0124? | Extend token metadata for translations #488
Conversation
Add a property for string localization to prepare NFTs and metaverse solutions for mass adoption.
Added first draft of CIP proposal with implementation examples.
Added copyright section.
Added strings localization support for collections and for multi-asset policies.
Changed TypeScript implementation.
Added Github repos and relevant links for proposal authors.
Reverted last changes as it breaks YAML syntax
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rename your project folder from CIP-1856
to something else beginning with CIP-
but not a number (derived from your proposal name, or ????
). This is relatively important for 1856
because we had a potential CIP-1856 for a while: #104
Adjustment CIP ID from pull request review. Co-authored-by: Robert Phair <rphair@cosd.com>
Changed Status to "Proposed" Co-authored-by: Robert Phair <rphair@cosd.com>
Simplified title according to pull request review. Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Robert Phair <rphair@cosd.com>
Improved wording on Abstract and Motivation.
Fixed YAML
Added Implementation plan and updated standard extension proposal with alternative to reduce the size of the metadata.
Thanks @granada-pool for the latest updates & including the peer review from NMKR. Can you please rename the project folder from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Padierfind if you could please assist here:
- This proposal seems good enough for me to approve (mainly based on web standards experience; I'm not a token metadata expert) if we could have a peer review, or even just an acknowledgement, of this PR coming from the NMKR direction.
- If there are any revisions to how your peer review is presented in the CIP please suggest alternative language and/or discuss it in this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@granada-pool this was generally seen at tonight's CIP meeting to be ready to progress to the final Last Check
stage before merge as soon as @Ryun1's feedback above is addressed. (The CDDL spec is a rather big thing that it needs first.)
Please also change the containing directory name to CIP-0124
🎉
@granada-pool are you still advocating this? Based on no response to the 2 reviews above it appears abandoned & so we're tagging at such (it's not really It would seem a shame to close this PR after you have basically done all the work, so please respond to the feedback above if & when you can. (Proposals marked as apparently "Abandoned" will be closed some time afterward if no further progress is made.) |
Co-authored-by: Robert Phair <rphair@cosd.com>
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
Co-authored-by: Ryan <44342099+Ryun1@users.noreply.github.com>
…dded CDDL files with the extended standard based on CIP-25.
@rphair Great to know! I just made some changes based on your comments and suggestions |
@rphair Absolutely! I apologize for the delay, I had quite a lot on my plate with the development of VAULT3 and the RareEvo event. Hope the changes made today satisfy all reviews. Please tag me if there are more improvements to make. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @granada-pool - just one last pass for me before we try to push this through:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(accidentally hit "Submit" button above)
Co-authored-by: Robert Phair <rphair@cosd.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@granada-pool I think we are all in order now although I will leave it to @Ryun1 @Crypto2099 to confirm the CDDL spec + recent updates. Marking as Last Check
since I think this is now good to finally merge as soon as we have their confirmation.
This proposal defines an additional property to the NFT and FT metadata standard to support text localization.
(rendered proposal in branch)