Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0105? | Conway Era Key Chains for HD Wallets #597

Merged
merged 12 commits into from
Nov 28, 2023

Conversation

Ryun1
Copy link
Collaborator

@Ryun1 Ryun1 commented Sep 27, 2023

The Conway Ledger era introduces many new features to Cardano, notably features to support community governance via CIP-1694. This includes the introduction of the new first class credentials; drep_credential, committee_cold_credential and committee_hot_credential.

We propose a HD wallet key derivation paths for registered DReps and constitutional committee members to deterministically derive keys from which credentials can be generated. Such keys are to be known as DRep keys, constitutional committee cold keys and constitutional committee hot keys. Here we define some accompanying tooling standards.

TODO:

  • Add definitions for "Constitutional Committee keys".
  • Add rationale for Constitutional keys

📰 Rendered proposal on branch

@Ryun1 Ryun1 added the Category: Wallets Proposals belonging to the 'Wallets' category. label Sep 27, 2023
@rphair
Copy link
Collaborator

rphair commented Oct 1, 2023

@Ryun1 I've put this on the meeting # 74 agenda so you can introduce it & maybe give it a quick review if attendees are up for it? 🤔

@Ryun1
Copy link
Collaborator Author

Ryun1 commented Nov 13, 2023

I have addressed all outstanding todos, and have added this to meeting # 76 agenda.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is well presented, well maintained in advance & consistent with itself and other updated CIPs. Practically all questions I had when reading the material are answered... one of them right in the Rationale FAQ. This should be well understandable to both users & implementors and useful to the community at large as governance issues come to the fore next year. I would recommend that this be made a candidate at tomorrow's CIP meeting. 👍

CIP-conway-keys/README.md Outdated Show resolved Hide resolved
@rphair rphair changed the title CIP-???? | Conway Era Key Chains for HD Wallets CIP-0105? | Conway Era Key Chains for HD Wallets Nov 15, 2023
@rphair rphair added the State: Last Check Review favourable with disputes resolved; staged for merging. label Nov 15, 2023
@rphair
Copy link
Collaborator

rphair commented Nov 15, 2023

Welcome to the family #105 (in anticipation of Last Check at next CIP meeting # 77, 2 weeks from today: https://hackmd.io/@cip-editors/77); please update the directory name & Rendered proposal on branch link 🤩 ... I'll green-tick this as soon as the housekeeping is done ✅

Copy link
Collaborator

@Crypto2099 Crypto2099 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything now looks in order from what I can see.

Copy link
Collaborator

@rphair rphair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all set then... ready to merge whenever ready from your end @Ryun1 😎

@gitmachtl
Copy link
Contributor

Constitutional Committee Cold Keys derived:

cardano-signer keygen --path cc-cold --vkey-extended --json-extended
{
  "workMode": "keygen",
  "path": "1852H/1815H/0H/4/0",
  "mnemonics": "tube sport this leg couch tooth live place relief tenant kite fiscal travel wasp lion lady insect duty sure together edit before silent suspect",
  "secretKey": "2085e1acca5...7974407dfa10f08e0cd96048a9fe4d0555003fe9f86b4a408c6531e354d2aa514e252fa88cb81c7966641911ee015b28f0ed4eb26d0",
  "publicKey": "516f025e8d41ec21ff30a7974407dfa10f08e0cd96048a9fe4d0555003fe9f86b4a408c6531e354d2aa514e252fa88cb81c7966641911ee015b28f0ed4eb26d0",
  "XpubKeyHex": "ddbaf1524a2a0307c9b661e5f335e06103821e4e23d5aa68ae3b66efc9642c0c33b84c0267f2d22c537ee26dff5149253aa660b8a1e0726454809e4d0e877d1e",
  "XpubKeyBech": "xpub1mka0z5j29gps0jdkv8jlxd0qvypcy8jwy026569w8dnwljty9sxr8wzvqfnl953v2dlwym0l29yj2w4xvzu2rcrjv32gp8jdp6rh68sd9jlea",
  "ccColdIdHex": "f99fc61869992baa2ae384ce1f68b87ccd12a056b1bc835b26b98017",
  "ccColdIdBech": "cc_cold1lx0uvxrfny4652hrsn8p769c0nx39gzkkx7gxkexhxqpwr4ccr3",
  "secretKeyBech": "cc_cold_xsk1yzz7rtx2t4neh0h982qq...v98jazq0happuywpnvkqj9flexs24gq8l5ls662gzxx2v0r2nf2552wy5h63r9cr3ukveqez8hqzkeg7rk5avndqw5uhjr",
  "publicKeyBech": "cc_cold_xvk129hsyh5dg8kzrles57t5gp7l5y8s3cxdjczg48ly6p24qql7n7rtffqgcef3ud2d92j3fcjjl2yvhqw8jenyryg7uq2m9rcw6n4jd5qst2a88",
  "output": {
    "skey": {
      "type": "ConstitutionalCommitteeColdExtendedSigningKey_ed25519_bip32",
      "description": "Constitutional Committee Cold Extended Signing Key",
      "cborHex": "58802085e1acca5d679bbee53a800.....974407dfa10f0d96048a9fe4d0555003fe9f86b4a408c6531e354d2aa514e252fa88cb81c7966641911ee015b28f0ed4eb26d0"
    },
    "vkey": {
      "type": "ConstitutionalCommitteeColdExtendedVerificationKey_ed25519_bip32",
      "description": "Constitutional Committee Cold Extended Verification Key",
      "cborHex": "5840516f025e8d41ec21ff30a7974407dfa10f08e0cd96048a9fe4d0555003fe9f86b4a408c6531e354d2aa514e252fa88cb81c7966641911ee015b28f0ed4eb26d0"
    }
  }
}

Constitutional Committee Hot Keys derived:

cardano-signer keygen --path cc-hot --vkey-extended --json-extended
{
  "workMode": "keygen",
  "path": "1852H/1815H/0H/5/0",
  "mnemonics": "help under taste three yellow draw shoulder castle donor urge present because wise borrow prepare mango guilt quote bracket inside obvious harbor siren online",
  "secretKey": "f81096d00a4fcf6ccaf00d4...fd3deb4c5433fef9847be08394f404ab4b1e3f9e8f49107fe4acf518f332a78ea2c7097d912d4fd81c68ee4c6267e7bc3cd7e037e0",
  "publicKey": "34570e6f59b60b05d3242afd3deb4c5433fef9847be08394f404ab4b1e3f9e8f49107fe4acf518f332a78ea2c7097d912d4fd81c68ee4c6267e7bc3cd7e037e0",
  "XpubKeyHex": "1aba5a0005b27cb57291fdb24683070c12d4f044d8223b131ab10e8fa99be3bb6147b5ada1267d1c6773217da209944f28905fd1f58a544507a0ba054278be92",
  "XpubKeyBech": "xpub1r2a95qq9kf7t2u53lkeydqc8psfdfuzymq3rkyc6ky8gl2vmuwakz3a44ksjvlguvaejzldzpx2y72ystlgltzj5g5r6pws9gfutayszlzyft",
  "ccHotIdHex": "bf5f496e660543d02c6ac09853df9959c687d12d91b8c8ecbbeb0013",
  "ccHotIdBech": "cc_hot1ha05jmnxq4paqtr2czv98huet8rg05fdjxuv3m9mavqpxska8d0",
  "secretKeyBech": "cc_hot_xsk1lqgfd5q2fl8kejhsp49pw9jv0fd6qq...kpvzaxfp2l577knz5x0l0nprmuzpefaqy4d93u0u73ay3qlly4n633uej578293cf0kgj6n7cr35wunrzvlnmc0xhuqm7qtcjck6",
  "publicKeyBech": "cc_hot_xvk1x3tsum6ekc9st5ey9t7nm66v2sela7vy00sg8985qj45k83ln685jyrlujk02x8nx2ncagk8p97ezt20mqwx3mjvvfn700pu6lsr0cqxj5uws",
  "output": {
    "skey": {
      "type": "ConstitutionalCommitteeHotExtendedSigningKey_ed25519_bip32",
      "description": "Constitutional Committee Hot Extended Signing Key",
      "cborHex": "5880f81096d00a4fcf6ccaf00d4a17164c7a5ba002ba...5433fef9847be0839f9e8f49107fe4acf518f332a78ea2c7097d912d4fd81c68ee4c6267e7bc3cd7e037e0"
    },
    "vkey": {
      "type": "ConstitutionalCommitteeHotExtendedVerificationKey_ed25519_bip32",
      "description": "Constitutional Committee Hot Extended Verification Key",
      "cborHex": "584034570e6f59b60b05d3242afd3deb4c5433fef9847be08394f404ab4b1e3f9e8f49107fe4acf518f332a78ea2c7097d912d4fd81c68ee4c6267e7bc3cd7e037e0"
    }
  }
}

@rphair rphair merged commit 0f64c52 into cardano-foundation:master Nov 28, 2023
Ryun1 added a commit to Ryun1/CIPs that referenced this pull request Mar 6, 2024
)

* conway-keys CIP intial commit

* add CC cold and hot keys

* further details on CC keys

* small correction

* add CC to rationale

* small tidy

* fix extended key type naming, thanks @gitmachtl

* missed _bip32 for CC hot key type

* align with CIP number 105

* credentail serilisation correction

* revert last crdential serilzation changes

* clarification around credential array
@rphair rphair removed the State: Last Check Review favourable with disputes resolved; staged for merging. label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Wallets Proposals belonging to the 'Wallets' category.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants