Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIP-0017 | Adjust preamble and structure w.r.t CIP-0001 #662

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

rphair
Copy link
Collaborator

@rphair rphair commented Dec 20, 2023

@rphair
Copy link
Collaborator Author

rphair commented Dec 20, 2023

@KtorZ when we were originally reviewing this it seemed like this was on the threshold of implementation, especially since Adafolio was already half way there, and maybe that's why it was merged as Active without the evidence that we would demand today.

Based on our current standards I've demoted it to Proposed but if you known of anything that qualifies it as Active then please post & we'll have another look. I was also liberal about writing your Path to Active based on what we might expect along those lines & would be open to your suggestions or corrections.

Copy link
Collaborator

@Ryun1 Ryun1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CIP-0017/README.md Outdated Show resolved Hide resolved
CIP-0017/README.md Outdated Show resolved Hide resolved
@KtorZ
Copy link
Member

KtorZ commented Jan 4, 2024

@KtorZ when we were originally reviewing this it seemed like this was on the threshold of implementation, especially since Adafolio was already half way there, and maybe that's why it was merged as Active without the evidence that we would demand today.

Indeed, that is odd. I've demoted it even further to Inactive since it hasn't really gained any traction and I am not aware of any work stream (and surely not leading any) to implement it and further refine it.

Co-authored-by: Matthias Benkort <5680256+KtorZ@users.noreply.github.com>
@rphair
Copy link
Collaborator Author

rphair commented Jan 4, 2024

Still @KtorZ I think it'll be helpful as a point of reference since the idea of the JSON portfolio has come up in other arrangements (e.g #628) & will keep coming up. I've changed the status... does anything else need to be reconsidered?

@rphair rphair requested a review from KtorZ January 4, 2024 15:59
@KtorZ KtorZ merged commit 7551573 into cardano-foundation:master Jan 5, 2024
@rphair rphair removed the Remediation label Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CIP-0017 | Adjust preamble and structure w.r.t CIP-0001
3 participants