chore: upgraded db-sync #885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niso1985
reviewed
Aug 14, 2024
| cardano-node: | ||
| condition: service_healthy | ||
| postgres: | ||
| condition: service_healthy |
There was a problem hiding this comment.
@Kammerlo
healthcheck is not defined for cardano-node and postgres. Is this a problem?
There was a problem hiding this comment.
No this isn't a problem. We just need the container to be up and running.
There was a problem hiding this comment.
In that case, shouldn't we use service_started instead of service_healthy?
I am making such a change locally.
There was a problem hiding this comment.
I am trying it in a preprod environment right now and it wouldn't start otherwise.
Aug 14 13:13:51 ip-10-18-1-87.ap-northeast-1.compute.internal docker-compose[6159]: ERROR: for cardano-db-sync Service "postgres" is missing a healthcheck configuration
Aug 14 13:13:51 ip-10-18-1-87.ap-northeast-1.compute.internal docker-compose[6159]: Encountered errors while bringing up the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading db-sync to 13.4.0.0 this fixes an issue which leads to crashes when trying to sync up using a snapshot