feat: balance tx fails fast on txcoll or collRet

[Unisay]

balanceTransaction fails gracefully if Tx body contains either total collateral attribute or collateral return outputs attribute.

Issue Number

ADP-1653

[Anviking]

Neat!

For testing I think it would be very nice if we could:

1. make prop_balanceTransactionValid run in both Alonzo and Babbage which would be valuable irrespective of this task. I think and hope this is not that complicated.

2. Generate a tiny amount of totalCollateral and returnCollateral in https://github.com/input-output-hk/cardano-wallet/blob/f5cff1c23260c6985f9007b0b5ac8fb29be631ae/lib/core/src/Cardano/Api/Gen.hs#L1335-L1337

And actually, we could then perhaps add some checks here to mimic the ledger rules

to make the tests fail unless we have guardExisting{Return, Total}Collateral .

[jonathanknowles]

Hi @Unisay

Thanks for making this PR! I've left a few suggestions and comments.

[Anviking]

Thanks a lot, LGTM! As discussed it would be cool to extend prop_balanceTransactionValid with the collateral rules for a "higher level" property, but we don't have to do that now.

But I would like ask to split up at least the swagger-reformatting into a separate commit before merging (see comments).

[Unisay]

bors r+

[iohk-bors]

Build succeeded:

• buildkite/cardano-wallet
• ci/hydra-build:required