Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix script validity #3365

Merged
merged 6 commits into from
Jun 29, 2022
Merged

Fix script validity #3365

merged 6 commits into from
Jun 29, 2022

Conversation

paweljakubas
Copy link
Contributor

@paweljakubas paweljakubas commented Jun 29, 2022 •
edited by piotr-iohk
Loading

Issue Number

ADP-1970
ADP-1969

Tasks

  • Make sure script validity is propagated upwards for Alonzo and Babbage (Pawel)
  • Add e2e tests showing proper collateral accounting and behaviour when script is invalid in the second phase validation (Piotr) -> in Collateral outputs e2e testing #3367

Comments

@piotr-iohk
Copy link
Contributor

I have added e2e test in #3367. The test passes on the branch with the fix 👍.

piotr-iohk
piotr-iohk approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
E2e test confirms it works!

@piotr-iohk
Merge pull request #3367 from input-output-hk/piotr/collateral-inpts-…
5d4bc65 
…outpts-e2e-testing

Collateral outputs e2e testing
@paweljakubas
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Jun 29, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 796032a into master Jun 29, 2022
@iohk-bors iohk-bors bot deleted the paweljakubas/adp-xxxx/fix-script-validity branch June 29, 2022 15:55
WilliamKingNoel-Bot pushed a commit that referenced this pull request Jun 29, 2022
docs: Merge #3365
dbac1f4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piotr-iohk piotr-iohk piotr-iohk approved these changes

@jonathanknowles jonathanknowles Awaiting requested review from jonathanknowles

Assignees

@paweljakubas paweljakubas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paweljakubas @piotr-iohk