Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Party from ν_commit datum #242

Closed
Tracked by #181
abailly-iohk opened this issue Mar 8, 2022 · 4 comments · Fixed by #267
Closed
Tracked by #181

Drop Party from ν_commit datum #242

abailly-iohk opened this issue Mar 8, 2022 · 4 comments · Fixed by #267
Labels
task Subtask of a bigger feature.

Comments

@abailly-iohk
Copy link
Contributor

No description provided.

@abailly-iohk abailly-iohk mentioned this issue Mar 8, 2022
Closed
5 tasks
@abailly-iohk abailly-iohk added the task Subtask of a bigger feature. label Mar 8, 2022
abailly-iohk added a commit that referenced this issue Mar 11, 2022
@abailly-iohk
WIP: Shove PartyTable in chain state to observe commits #242
b2a01d4 
Tests don't compile
@ch1bo ch1bo mentioned this issue Mar 11, 2022
Closed
@ch1bo
Copy link
Collaborator

ch1bo commented Mar 11, 2022

To remove the headValidatorHash from the Datum, the v_head validator first needs to be unparameterized. That means, checkCollectCom and checkAbort need not use script addresses, but only the ST&PTs for finding initial & commit outputs.

@abailly-iohk
Copy link
Contributor Author

Can we split the task in two? Seems like we are "all green" (bar flakiness) for the first part anyway.
In general, having a and in the title is a smell :)

@abailly-iohk abailly-iohk changed the title Drop Party and move headValidatorHash as validate parameter from ν_commit datum Drop Party from ν_commit datum Mar 11, 2022
KtorZ pushed a commit that referenced this issue Mar 14, 2022
@abailly-iohk @KtorZ
WIP: Shove PartyTable in chain state to observe commits #242
aee98eb 
Tests don't compile
@abailly-iohk
Copy link
Contributor Author

We finally decided this change was not worth the effort of tracking some apparently subtle bugs it might have introduced.

@ch1bo
Copy link
Collaborator

ch1bo commented Mar 15, 2022

So to close this, we should instead revise "the diagram" to keep the Party in the v_commit datum and a note why so (to ease off-chain observing of commits).

@ch1bo ch1bo mentioned this issue Mar 16, 2022
Merged
ch1bo added a commit that referenced this issue Mar 16, 2022
@ch1bo
Update the full life cycle diagram
17d17c1 
We decided to keep the 'Party' in the commit datum for pure off-chain convenience. Closes #242
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task Subtask of a bigger feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update the full life cycle diagram cardano-scaling/hydra
2 participants
@ch1bo @abailly-iohk