Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plutus: 1.30 -> 1.34.1 #1544

Closed
wants to merge 2 commits into from
Closed

plutus: 1.30 -> 1.34.1 #1544

wants to merge 2 commits into from

Conversation

locallycompact
Copy link
Contributor

No description provided.

@ch1bo ch1bo force-pushed the master branch 2 times, most recently from 53b33e9 to 8d8d3a3 Compare August 15, 2024 17:09
@locallycompact locallycompact changed the title plutus: 1.30 -> 1.31 plutus: 1.30 -> 1.32 Aug 19, 2024
@locallycompact
Copy link
Contributor Author

Currently waiting for IntersectMBO/ouroboros-consensus#1207 to progress on 1.32

@locallycompact locallycompact force-pushed the lc/plutus-1.31 branch 2 times, most recently from 4b22075 to 73c1aa6 Compare September 7, 2024 10:10
@locallycompact locallycompact changed the title plutus: 1.30 -> 1.32 plutus: 1.30 -> 1.31 Sep 7, 2024
@locallycompact locallycompact force-pushed the lc/plutus-1.31 branch 2 times, most recently from e1f2dc3 to 31f0f44 Compare September 7, 2024 13:05
ch1bo
ch1bo reviewed Sep 9, 2024
View reviewed changes
hydra-plutus/scripts/mDeposit.plutus Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we would want to keep this file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't seem to be in the tests for this branch. I think the script got merged in the refactor but not the logic.

ch1bo
ch1bo reviewed Sep 9, 2024
View reviewed changes
cabal.project
@@ -41,3 +41,6 @@ benchmarks: True

-- Always show detailed output for tests
test-show-details: direct

allow-newer: base
allow-newer: plutus-ledger-api
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which packages do need these constraints? There is a nice syntax here to provide more context. I think it goes like: allow-newer: somepkg:base to say that somepkg needs to have its upper bounds removed for base

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't this is is noise.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is noise from ghc 9.10. Not relevant to this PR.

@locallycompact locallycompact force-pushed the lc/plutus-1.31 branch 4 times, most recently from 61aae8f to 662e3b9 Compare September 24, 2024 17:53
@locallycompact locallycompact changed the title plutus: 1.30 -> 1.31 plutus: 1.30 -> 1.34.1 Sep 24, 2024
@noonio noonio mentioned this pull request Sep 30, 2024
Closed
@ch1bo
Copy link
Collaborator

ch1bo commented Oct 4, 2024

I don't see the rationale for this PR (in isolation). Shall we just continue with #1680 instead?

@locallycompact
Copy link
Contributor Author

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch1bo ch1bo ch1bo left review comments

Assignees

@locallycompact locallycompact

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@locallycompact @ch1bo