-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: Add publishing to Open VSX #1904
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should this be in a different job? 🤔
backspace
force-pushed
the
tools/open-vsx-cs-7624
branch
from
December 9, 2024 22:02
3fb2341
to
0225311
Compare
lukemelia
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a step to the Boxel Tools deployment job to publish to Open VSX. It would normally only run on a deployment but I added hacks to publish from this PR, you can see the release here. (The warning should be addressed by this issue).
I originally had a script in
packages/vscode-boxel-tools/package.json
akin to the Visual Studio Marketplacevscode:publish
ones but it revealed thatpnpm run …
commands are executing with Node 18 andovsx
requires Node 20. This should be addressed separately (issue 7650).