Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ai: Add attachment for JSON parse failure #1920

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

backspace
Copy link
Contributor

It’s helpful when seeing an error like this to have the data attached that failed to parse:

AI-BOT-P - SyntaxError: Unexpected token o in JSON at position 1 - buck doyle@cardstack com - Cardstack Mail 2024-12-11 12-16-06

I’d prefer this to be applied through the whole codebase but it’s not clear to me how to easily accomplish that, something to think about if we keep getting errors like this elsewhere.

@backspace backspace self-assigned this Dec 11, 2024
@backspace backspace added the bug Something isn't working label Dec 11, 2024
Copy link

github-actions bot commented Dec 11, 2024

Host Test Results

    1 files  ±0      1 suites  ±0   20m 19s ⏱️ -12s
710 tests ±0  709 ✔️ ±0  1 💤 ±0  0 ±0 
715 runs  ±0  714 ✔️ ±0  1 💤 ±0  0 ±0 

Results for commit 2461013. ± Comparison against base commit 9d610f8.

♻️ This comment has been updated with latest results.

@backspace backspace marked this pull request as ready for review December 11, 2024 22:23
@backspace backspace requested a review from a team December 11, 2024 22:23
Copy link
Contributor

@lukemelia lukemelia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@backspace backspace merged commit 02d8636 into main Dec 11, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants