Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce percentage field #1932

Merged
merged 1 commit into from
Dec 13, 2024
Merged

Introduce percentage field #1932

merged 1 commit into from
Dec 13, 2024

Conversation

richardhjtan
Copy link
Contributor

Refer to https://linear.app/cardstack/issue/CS-7415/create-percentagefield

What is changing

  • introduce the percentage field inherited from NumberField
  • display {percentage with 2 decimal points}% across atom, isolated embedded view

Screenshot
Screenshot 2024-12-13 at 2 31 34 PM

@richardhjtan richardhjtan requested a review from a team December 13, 2024 06:37
Copy link

Host Test Results

    1 files  ±0      1 suites  ±0   21m 17s ⏱️ + 1m 0s
710 tests ±0  708 ✔️ ±0  2 💤 ±0  0 ±0 
715 runs  ±0  713 ✔️ ±0  2 💤 ±0  0 ±0 

Results for commit 38c1b78. ± Comparison against base commit 49561c6.

@richardhjtan richardhjtan merged commit c4ffc5e into main Dec 13, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants