Skip to content

Commit

Permalink
Fix typo for midplane APIs. (sonic-net#196)
Browse files Browse the repository at this point in the history
In midplane API, default method should be raise NotImplementedError not return NotImplementedError
  • Loading branch information
caizhenghui-juniper authored Jun 11, 2021
1 parent fc2e9e2 commit 4e3a0a0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sonic_platform_base/module_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -451,7 +451,7 @@ def get_midplane_ip(self):
A string, the IP-address of the module reachable over the midplane
"""
return NotImplementedError
raise NotImplementedError

def is_midplane_reachable(self):
"""
Expand All @@ -461,4 +461,4 @@ def is_midplane_reachable(self):
Returns:
A bool value, should return True if module is reachable via midplane
"""
return NotImplementedError
raise NotImplementedError

0 comments on commit 4e3a0a0

Please sign in to comment.