Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-rendering mode #469

Merged
merged 4 commits into from
Sep 6, 2018
Merged

Non-rendering mode #469

merged 4 commits into from
Sep 6, 2018

Conversation

juaxix
Copy link
Contributor

@juaxix juaxix commented Jun 4, 2018

Changes to enable or disable rendering of the world (Unreal render) and CARLA HUDs (Unreal HUD rendering) using a property of the server settings.

The changes involve:

  • Clients can use the DisableRendering flag
  • Added the option in : Carla.Settings.ini -> [CARLA/Server] -> DisableRendering
  • Added the argument for runtime : "-disable-rendering"
  • Tests needed

Example

Using the code for manual_control.py, with this modification:

def make_carla_settings(args):
    """Make a CarlaSettings object with the settings we need."""
    settings = CarlaSettings()
    settings.set(
        SynchronousMode=True,
        SendNonPlayerAgentsInfo=True,
        NumberOfVehicles=15,
        NumberOfPedestrians=30,
        WeatherId=random.choice([1, 3, 7, 8, 14]),
        QualityLevel=args.quality_level,
        DisableRendering=True)
    settings.randomize_seeds()
    if args.lidar:
        lidar = sensor.Lidar('Lidar32')
        lidar.set_position(0, 0, 2.5)
        lidar.set_rotation(0, 0, 0)
        lidar.set(
            Channels=32,
            Range=50,
            PointsPerSecond=100000,
            RotationFrequency=10,
            UpperFovLimit=10,
            LowerFovLimit=-30)
        settings.add_sensor(lidar)
    return settings

we are removing all the sensors except for the lidar. We can launch the client with a command like this:

PythonClient$ python manual_control.py -a -l

Screenshot of the result :
example_no_render

Where has this been tested?

  • **Platform(s): Windows and Linux
  • **Python version(s): ** 2.6, 3
  • Unreal Engine version(s): 4.18.3

Possible Drawbacks

You may want to draw huds?

child of #286.


This change is Reviewable

@juaxix juaxix requested a review from nsubiron June 4, 2018 08:05
@ghost ghost assigned juaxix Jun 4, 2018
@ghost ghost added the review label Jun 4, 2018
@stale
Copy link

stale bot commented Aug 11, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issue has not had recent activity label Aug 11, 2018
@stale stale bot closed this Aug 18, 2018
@ghost ghost removed the review label Aug 18, 2018
@nsubiron
Copy link
Collaborator

Whoops, stalebot closed this during our holidays 😅

@nsubiron nsubiron reopened this Aug 20, 2018
@stale stale bot removed the stale Issue has not had recent activity label Aug 20, 2018
@ghost ghost assigned nsubiron Aug 20, 2018
@ghost ghost added the review label Aug 20, 2018
@nsubiron
Copy link
Collaborator

Rebased specific commits onto master to remove dependencies with #445.

@nsubiron nsubiron requested review from marcgpuig and removed request for nsubiron August 24, 2018 14:30
Copy link
Contributor

@marcgpuig marcgpuig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 7 files at r1, 4 of 4 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@nsubiron nsubiron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r3, 4 of 4 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @juaxix)

@nsubiron nsubiron merged commit a1684ad into master Sep 6, 2018
@nsubiron nsubiron deleted the issue#286 branch September 6, 2018 16:03
@ghost ghost removed the review label Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants