Remove dependency on winapi 0.2 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead declare the few types we use directly in the crate to avoid bringing in the old winapi 0.2 dependency. Fixes carllerche#16. Replaces previous attempts carllerche#19 carllerche#22 carllerche#24.
This was referenced Sep 20, 2019
Same as mio 0.6
|
@carllerche does this look good? |
carllerche
approved these changes
Oct 9, 2019
|
Thanks. I'll push this out. Unfortunately, it won't help any on the Tokio / mio stack until the next major release, but it is a step. |
tesuji
reviewed
Oct 9, 2019
| type ULONG = u32; | ||
| type CHAR = i8; | ||
|
|
||
| struct WSABUF { |
There was a problem hiding this comment.
you're right, missed that, damn. will do PR
This was referenced Dec 16, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead declare the few types we use directly in the crate to avoid bringing in the old
winapi 0.2crate.Fixes #16.
Replaces previous attempts #19 #22 #24.