Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating 💡 emoji description #454

Merged
merged 4 commits into from
Jun 12, 2020
Merged

Updating 💡 emoji description #454

merged 4 commits into from
Jun 12, 2020

Conversation

Lyokolux
Copy link
Contributor

Description

Related to #397.
Preference go to updating the already existing 💡 emoji description to "Adding or updating comments in code" as it is the most upvoted comment.

Tests

  • All tests passed.

@Lyokolux Lyokolux changed the title Refactor/397 Updating 💡 emoji description #397 Jun 11, 2020
@Lyokolux Lyokolux changed the title Updating 💡 emoji description #397 Updating 💡 emoji description Jun 11, 2020
vhoyer
vhoyer reviewed Jun 11, 2020
View reviewed changes
src/data/gitmojis.json Outdated Show resolved Hide resolved
Lyokolux and others added 2 commits June 12, 2020 00:39
@Lyokolux @vhoyer
👌 src/data/gitmojis.json
a8299fd 
Co-authored-by: Vinícius Hoyer <contact@vhoyer.dev>
@Lyokolux
📸
d02402d
@vhoyer vhoyer linked an issue Jun 12, 2020 that may be closed by this pull request
Add new 💭emoji for adding / modifying informative comments in code #397
Closed
vhoyer
vhoyer approved these changes Jun 12, 2020
View reviewed changes
Copy link
Collaborator

@vhoyer vhoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for your contribution.

@vhoyer vhoyer merged commit 966c8df into carloscuesta:master Jun 12, 2020
benavern pushed a commit to benavern/gitmoji that referenced this pull request Aug 25, 2020
@Lyokolux @vhoyer @benavern
💬 Clarify 💡 description as for alterations on comments (carloscuesta#454
42062c3 
)

* 💬(gitmojis.json): improve clarity of the bulb description

* 📸

* 👌 src/data/gitmojis.json

Co-authored-by: Vinícius Hoyer <contact@vhoyer.dev>

* 📸

Co-authored-by: Vinícius Hoyer <contact@vhoyer.dev>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vhoyer vhoyer vhoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add new 💭emoji for adding / modifying informative comments in code
2 participants
@Lyokolux @vhoyer