Reword 🎉 to "Begining a project" #456
Conversation
|
I really love this idea but I'm a bit confused by the term 'project' 😅 What would this word project cover? |
|
hmm, what do you think project cover? |
|
🤔 let's define this better, because, you see, I'm primarily a JavaScript developer, so for me, a project would be anytime you create a folder and insert a |
|
Correct me if I'm wrong but this action can be covered by ✨ right ? 🤔 |
|
well, yeah, in theory you could also use ✨ with the initial commit, but we have it anyway :D. actually, ✨ cover practically everything that is not a bug haha. The thing is that I'm bothered that we can only use the 🎉 once in a repository, like, why have an emoji like that, you know? The other thing is that, I try seeing the ✨ as like adding features to the user. So, creating a playground project is not a feature for the user, the initial commit, is not feature for the user. Creating a new package in a mono repo... well, this can be depending on how you split your commits. But if we take for example the way I would create a new package (the way I already did it in the near past) is like "🎉 create package X" and the content would be just "package.json; .gitignore; readme.md" |
|
Well, as this PR is 10 days old.... I think we can merge, right? It's plenty of time for waiting for opinions on this, right? |
|
@vhoyer Sure just merge it 🚀 I think there would be no problem for @carloscuesta 👍 |
This will enable 🎉 to be used more than once in a repository since we can have multiple projects in a monorepo, for example. Or it can be used in a library repository, to add a playground project to test this library. Closes #294
This will enable 🎉 to be used more than once in a repository since we can have multiple projects in a monorepo, for example. Or it can be used in a library repository, to add a playground project to test this library. Closes carloscuesta#294
Description
This will enable 🎉 to be used more than once in a repository since
we can have multiple projects in a monorepo, for example. Or it can be
used in a library repository, to add a playground project to test
this library.
Closes #294
Tests